Skip to content

refactor: use GitHub native popover to substitue ours #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tyn1998 merged 11 commits into from
Apr 29, 2024
Merged

refactor: use GitHub native popover to substitue ours #795

tyn1998 merged 11 commits into from
Apr 29, 2024

Conversation

@tyn1998
Copy link
Member

@tyn1998 tyn1998 commented Apr 24, 2024 •
edited
Loading

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

NativePopover.mov-8mb.mp4

Checklist

Others

@tyn1998 tyn1998 marked this pull request as draft April 24, 2024 12:25
tyn1998
tyn1998 commented Apr 24, 2024
View reviewed changes
Copy link
Member Author

@tyn1998 tyn1998 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lhbvvvvv, the first commit in this PR shows the possibility to use GitHub's native Popover to present our content. The code in this commit looks messy and dirty but it works. I will keep working on this PR :)

image

@tyn1998 tyn1998 force-pushed the refactor/native-popover branch from a6774de to 5ef1845 Compare April 24, 2024 12:30
@tyn1998 tyn1998 force-pushed the refactor/native-popover branch from 5ef1845 to 22c91ff Compare April 24, 2024 12:46
@tyn1998
Copy link
Member Author

tyn1998 commented Apr 24, 2024

2024-04-24.23.05.15.mov

Hello @lhbvvvvv, I have implemented a component called NativePopover and I think you may refactor other remaining tooltip features using this component :)

@tyn1998 tyn1998 requested a review from l1tok April 24, 2024 15:08
tyn1998
tyn1998 commented Apr 29, 2024
View reviewed changes
Copy link
Member Author

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lhbvvvvv, thank you for refactoring issue, pr, fork, star Tooltips with NativePopover. They look good!

@tyn1998 tyn1998 mentioned this pull request Apr 29, 2024
Closed
@tyn1998 tyn1998 marked this pull request as ready for review April 29, 2024 14:03
tyn1998
tyn1998 commented Apr 29, 2024
View reviewed changes
Copy link
Member Author

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and guys welcome to your local test and screenshots @wxharry @lhbvvvvv @andyhuang18 @wangyantong2000 🚀

@tyn1998 tyn1998 changed the title WIP: refactor: use GitHub native popover to substitue ours refactor: use GitHub native popover to substitue ours Apr 29, 2024
@tyn1998 tyn1998 merged commit 1126d27 into hypertrons:master Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@l1tok l1tok Awaiting requested review from l1tok

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Refactor] refactor tooltips with GitHub Popover [Bug] tooltip position is not correct when first rendered

2 participants

@tyn1998 @l1tok