-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement of repo collection [OSPP 2023] #713
feat: implement of repo collection [OSPP 2023] #713
Conversation
d2e6db9
to
6dde36c
Compare
382b9ac
to
b5b428a
Compare
Report on work completed so far:
|
Simply recorded a demo video, the operations include adding collection, deleting collection, adding current repo to collection, resetting default values. demo.for.repo-collection.2023.08.15.mp4 |
Hi, I have changed the base branch for this PR. Since you and wj are working this feature together, we cannot merge your work one by one. So, I create a feature branch so that you can work closely together and develop in a relative fast pace. For this PR, please implement Frame 1, 2, 3. It is okay to ignore styles and unrelated features for this PR. Thanks! |
At present, the button function of the repository page has been initially implemented, and you can check which collection the repository belongs to when you click it for the first time. After clicking edit, you can enter the checkbox list and add it to a new collection. Clicking on the collection to pop up the modal in the repository interface has not yet been implemented, but it can capture the parameters that need to be transmitted. In addition, click collection on the pop-up interface (it is blocked in the video), and the modal can pop up. The top of the modal is composed of tabs named after the collection. The left side displays the repository information contained in the collection. The demo video is shown below: demo.video.mp4The problem currently encountered is that sometimes when managing the state of an object, the value of the object cannot be changed. (However, it is possible to increase a certain attribute of an object, but not to decrease it, which is confusing...) |
I have initially implemented the function of calling the modal from the button in the dropdown under the repository left yesterday. The demo video is shown below: demo.of.modal.from.dropdown.click.mov |
src/pages/ContentScripts/features/repo-collection/Mydropdown.tsx
Outdated
Show resolved
Hide resolved
src/pages/ContentScripts/features/repo-collection/Mydropdown.tsx
Outdated
Show resolved
Hide resolved
The demo video is shown below: demo.for.collection.editor.mov |
5985749
to
20f3cdc
Compare
demo.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do a chore on your code by removing unnessary comments and use english in comments. Thank you so much.
src/pages/ContentScripts/features/repo-collection/CollectionModal/CollectionEditor.tsx
Outdated
Show resolved
Hide resolved
src/pages/ContentScripts/features/repo-collection/CollectionModal/CollectionEditor.tsx
Outdated
Show resolved
Hide resolved
src/pages/ContentScripts/features/repo-collection/CollectionModal/CollectionEditor.tsx
Outdated
Show resolved
Hide resolved
src/pages/ContentScripts/features/repo-collection/CollectionModal/CollectionEditor.tsx
Outdated
Show resolved
Hide resolved
Hi~ @wxharry @tyn1998 This is the final version of my code! Please spare your time checking it! Thank you very much 😄 This is the part where repository can be added to the dropdown of the button: This is the modal interface, the middle part is the chart: This is the modalEditor interface, which can edit collection and repository: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @andyhuang18 !
Your code LGTM, thank you for your contributions!
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
PS: There is a small problem at present is that I want this button to be closer to the
Edit Pins
, that is, to the right.Things to be done:
Checklist
Others
I used the components of
ant design
to complete it, and welcome your valuable suggestions!