Skip to content

feat: adding abstract type #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2020
Merged

feat: adding abstract type #102

merged 1 commit into from
Nov 13, 2020

Conversation

anandtiwary
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.
Adding abstract type to ModelInject

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@anandtiwary anandtiwary requested a review from a team as a code owner November 13, 2020 20:56
@codecov
Copy link

codecov bot commented Nov 13, 2020

Codecov Report

Merging #102 (7ce37db) into main (2f51d49) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #102   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines          650       651    +1     
  Branches        61        61           
=========================================
+ Hits           650       651    +1     
Impacted Files Coverage Δ
...gular/src/model/decorators/model-inject.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f51d49...7ce37db. Read the comment docs.

@anandtiwary anandtiwary merged commit a8aaf26 into main Nov 13, 2020
@anandtiwary anandtiwary deleted the add-abstract-type branch November 13, 2020 21:08
@hypertrace-ci
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants