ENGTAI-63290: Upgrade to otel go v1.36.0#249
Merged
tim-mwangi merged 4 commits intomainfrom Jun 25, 2025
Merged
Conversation
varkey98
approved these changes
Jun 2, 2025
| } | ||
|
|
||
| wait := make(chan error) | ||
| wait := make(chan error, 1) |
Contributor
There was a problem hiding this comment.
do we not have to close this anymore?
Collaborator
Author
There was a problem hiding this comment.
Apparently. It's copied from otel go's batch span processor.
…ing because of this
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
- Coverage 53.35% 47.79% -5.57%
==========================================
Files 59 62 +3
Lines 2699 3013 +314
==========================================
Hits 1440 1440
- Misses 1185 1499 +314
Partials 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
varkey98
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade to otel go v1.36.0
Testing
Manual testing.
Checklist: