-
Notifications
You must be signed in to change notification settings - Fork 6
Modify the query conversion logic for multi valued fields #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify the query conversion logic for multi valued fields #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
final List<RelationalExpression> expressions = new ArrayList<>(); | ||
|
||
for (final Document document : list) { | ||
final ConstantExpression rhs = ConstantExpression.of(document.toJson()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
document.toJson()
-> document
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
============================================
+ Coverage 69.04% 69.14% +0.09%
- Complexity 647 650 +3
============================================
Files 109 110 +1
Lines 4545 4592 +47
Branches 487 493 +6
============================================
+ Hits 3138 3175 +37
- Misses 1151 1157 +6
- Partials 256 260 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Test Results 59 files ±0 59 suites ±0 33s ⏱️ +4s Results for commit 205d717. ± Comparison against base commit b7762c5. This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
No description provided.