Skip to content

Modify the query conversion logic for multi valued fields #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

suresh-prakash
Copy link
Contributor

No description provided.

Copy link
Contributor

@kotharironak kotharironak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

final List<RelationalExpression> expressions = new ArrayList<>();

for (final Document document : list) {
final ConstantExpression rhs = ConstantExpression.of(document.toJson());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document.toJson() -> document

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #236 (205d717) into main (b7762c5) will increase coverage by 0.09%.
The diff coverage is 84.90%.

@@             Coverage Diff              @@
##               main     #236      +/-   ##
============================================
+ Coverage     69.04%   69.14%   +0.09%     
- Complexity      647      650       +3     
============================================
  Files           109      110       +1     
  Lines          4545     4592      +47     
  Branches        487      493       +6     
============================================
+ Hits           3138     3175      +37     
- Misses         1151     1157       +6     
- Partials        256      260       +4     
Flag Coverage Δ
integration 69.14% <84.90%> (+0.09%) ⬆️
unit 52.79% <24.52%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...r/filter/ContainsFilteringExpressionConverter.java 80.48% <80.48%> (ø)
...ce/entity/query/service/converter/ValueHelper.java 82.44% <100.00%> (+0.41%) ⬆️
...ilter/FilteringExpressionConverterFactoryImpl.java 75.00% <100.00%> (+3.57%) ⬆️
...onverter/filter/RelationalExpressionConverter.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented May 19, 2023

Test Results

  59 files  ±0    59 suites  ±0   33s ⏱️ +4s
294 tests +1  293 ✔️ +1  1 💤 ±0  0 ±0 
296 runs  +1  295 ✔️ +1  1 💤 ±0  0 ±0 

Results for commit 205d717. ± Comparison against base commit b7762c5.

This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.
org.hypertrace.entity.query.service.converter.UpdateConverterTest ‑ [1] ATTRIBUTE_UPDATE_OPERATOR_ADD_TO_LIST_IF_ABSENT
org.hypertrace.entity.query.service.converter.UpdateConverterTest ‑ [2] ATTRIBUTE_UPDATE_OPERATOR_REMOVE_FROM_LIST
org.hypertrace.entity.query.service.converter.UpdateConverterTest ‑ [1] ATTRIBUTE_UPDATE_OPERATOR_REMOVE_FROM_LIST
org.hypertrace.entity.query.service.converter.UpdateConverterTest ‑ [2] ATTRIBUTE_UPDATE_OPERATOR_ADD_TO_LIST_IF_ABSENT
org.hypertrace.entity.service.service.EntityQueryServiceTest ‑ testExecuteWithNotInArrayFilter()

♻️ This comment has been updated with latest results.

@suresh-prakash suresh-prakash marked this pull request as ready for review May 19, 2023 12:30
@suresh-prakash suresh-prakash requested review from a team and kotharironak May 19, 2023 12:30
@suresh-prakash suresh-prakash merged commit 408a962 into main May 19, 2023
@suresh-prakash suresh-prakash deleted the modify_query_conversion_logic_for_multi_valued_fields branch May 19, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants