Implement bulkUpsert for flat collections #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suddendust
requested review from
avinashkolluru,
kotharironak,
skjindal93 and
suresh-prakash
as code owners
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
============================================
+ Coverage 80.44% 80.52% +0.07%
Complexity 1396 1396
============================================
Files 239 239
Lines 6598 6695 +97
Branches 605 615 +10
============================================
+ Hits 5308 5391 +83
- Misses 888 900 +12
- Partials 402 404 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| LOGGER.error("SQLException in bulkUpsertAndReturnOlderDocuments. query: {}", selectQuery, e); | ||
| if (connection != null) { | ||
| try { | ||
| connection.close(); |
There was a problem hiding this comment.
what about closing prepared statement here? Also, can we try reducing the complexity of this function?
Contributor
Author
There was a problem hiding this comment.
Closing a connection would close the PS associated with it too. Yes, refactored this method.
|
LGTM |
suddendust
changed the title
suresh-prakash
approved these changes
Feb 5, 2026
| public boolean bulkUpsert(Map<Key, Document> documents) { | ||
| throw new UnsupportedOperationException(WRITE_NOT_SUPPORTED); | ||
| if (documents == null || documents.isEmpty()) { | ||
| return true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Collection#bulkUpsertforFlatPostgresCollection.Testing
Added integration tests
Checklist:
Documentation
Note that based on the
MissingColumnStrategy, we either skip the corresponding docs (and), or just skip those columns, or throw an exception.