Allow "." (dot) in identifier names in BasicPostgresSecurityValidator#245
Merged
suresh-prakash merged 2 commits intohypertrace:mainfrom Oct 27, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=========================================
Coverage 80.10% 80.10%
Complexity 1134 1134
=========================================
Files 215 215
Lines 5488 5488
Branches 482 482
=========================================
Hits 4396 4396
Misses 764 764
Partials 328 328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suresh-prakash
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,
BasicPostgresSecurityValidatordoes not allow.(dots) in identifier names. Therefore, query containing columns with names likea.bare getting rejected. We should allow for dots of typea.bas such column names are pretty common use-case (note: We're still rejecting col names starting with a., ending with a.and containing two consecutivedots). This PR also refactors the code slightly by removing unnecessary comments and removing snake case from test method names.Checklist: