Skip to content

rails generator and react import misleading #347

Closed
@catmando

Description

@catmando

Rails generator leaves this line in hyperstack.rb

Hyperstack.cancel_import 'react/react-source-browser' # bring your own React and ReactRouter via Yarn/Webpacker

This is misleading. Latest Hyperstack does not import react/react-source-browser, so commenting this out, does nothing.

Instead this should read:

# Hyperstack.import 'react/react-source-browser' # uncomment this line if you want hyperstack to bring its copy of react

Metadata

Metadata

Assignees

No one assigned

    Labels

    compatibilitycompatibility with dependencies such as Rails, Opal, React, etc. NOT FUNCTIONAL COMPATIBILITYready-to-releaseInternal Use Only: Has been fixed, specs passing and pushed to edge branch

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions