Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pytest setuptools integration #2027

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Aug 3, 2018

Makes setup.py more consistent (see #2020) following [pytest good practices recommandation].(https://docs.pytest.org/en/latest/goodpractices.html#integrating-with-setuptools-python-setup-py-test-pytest-runner)

@francisco-dlp
Copy link
Member

Would it be good to:

  • Modify the Dev Guide to document this way of running the test
  • Add the --mpl option?

@ericpre
Copy link
Member Author

ericpre commented Aug 23, 2018

Adding --mpl should be possible but this feature will be deprecated soon, see pytest-dev/pytest#3523... but there may be alternative in the future. I put this on hold for now.

@dnjohnstone
Copy link
Contributor

Is this still relevant?

@tjof2
Copy link
Contributor

tjof2 commented Jun 19, 2020

Agree with @dnjohnstone - @ericpre is this, and the related issue #2020, still relevant? Or can the issue and PR both be closed.

@tjof2
Copy link
Contributor

tjof2 commented Aug 10, 2020

Sorry @ericpre that was meant to be sent as a pull request, not a push...!

@ericpre
Copy link
Member Author

ericpre commented Aug 12, 2020

In order to improve and simplify all these (testing, packaging, etc.), I suspect that it may be good looking at using pyproject.toml:

@jlaehne
Copy link
Contributor

jlaehne commented Mar 9, 2021

Any update on this one? Should it be included in 1.6.2?

@ericpre
Copy link
Member Author

ericpre commented Mar 9, 2021

I have left this one on hold, because I think that the build tool/configuration are still fluid at the moment... Closing it for now.

@ericpre ericpre closed this Mar 9, 2021
@ericpre ericpre deleted the improve_pytest_setuptolls_integration branch January 14, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants