Use key window bounds instead of screen bounds #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danwilliams64 Hi, thanks for the PR, that is a really good point. Can you use |
danwilliams64
force-pushed
the
fix/screen_bounds
branch
from
e44760e to
551cf22
Compare
danwilliams64
force-pushed
the
fix/screen_bounds
branch
from
551cf22 to
eb44646
Compare
|
Thanks for getting back to quickly – sure, I've just made that change. |
|
@danwilliams64 this is great 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome library! I've noticed that the layout breaks on iPad in split screen mode because it relies on a call to
UIScreen.main.boundsto perform layout calculations. I've switched to using the key window's bounds instead which fixes this problem.