Skip to content

Fix navigator #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
onmyway133 merged 4 commits into from
Jul 31, 2017
Merged

Fix navigator #50

onmyway133 merged 4 commits into from
Jul 31, 2017

Conversation

@onmyway133
Copy link
Contributor

@onmyway133 onmyway133 commented Jul 31, 2017

  • Add parse(urn) on Navigator. It performs percent encoding and call parse(url) to get Location
  • Remove unused properties and methods
  • Mark helper methods are fileprivate

@onmyway133 onmyway133 merged commit 1c57fb4 into master Jul 31, 2017
@onmyway133 onmyway133 deleted the fix/navigator branch July 31, 2017 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadymmarkov vadymmarkov Awaiting requested review from vadymmarkov

1 more reviewer

@zenangst zenangst zenangst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@onmyway133 @zenangst