Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata parser #253

Merged
merged 5 commits into from
Nov 9, 2017
Merged

Update metadata parser #253

merged 5 commits into from
Nov 9, 2017

Conversation

bcomnes
Copy link
Contributor

@bcomnes bcomnes commented Nov 9, 2017

Use music-metadata everywhere. It does a much better job than the old version we were using.

Also a few other things:

  • Delete dead code
  • Use bufferlist instead of a copy-pasta from2

Closes #185

On some large songs, this slows down like crazy, but in general its a lot faster.

We will have to dig in to why this is.
@bcomnes
Copy link
Contributor Author

bcomnes commented Nov 9, 2017

This improves the metadata and compatibility to a whole lot more files, even ones missing tag frames all together, and is generally a faster scan!

The drawback is that some of my larger DJ set type songs hang this up for some reason, and can cause 30-40 second delays on some tracks (specifically ones that were recorded from Shoutcast streams back in the day... don't ask).

Going to merge this now, since it provides some critical metadata fields like duration of all files... but we should figure out whats going on with these files and maybe try to send an upstream fix.

@bcomnes bcomnes added this to the Winamp 2 milestone Nov 9, 2017
@bcomnes bcomnes merged commit 7bfc482 into master Nov 9, 2017
@bcomnes bcomnes deleted the update-metadata-parser branch November 9, 2017 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant