Skip to content

Commit

Permalink
Merge pull request #260 from hypermodules/state-transfer-bugs
Browse files Browse the repository at this point in the history
Fixing state transfer bugs
  • Loading branch information
bcomnes authored Nov 10, 2017
2 parents 7bfc482 + 864118b commit eb93a40
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 5 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# hyperamp Change Log
All notable changes to this project will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org/).

## 0.5.3 - 2017-11-09
* Added this here changelog
* Fix some state transfer bugs

## 0.5.2 - 2017-11-10
* Engage
1 change: 1 addition & 0 deletions main/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ app.on('window-all-closed', function allWindowsClosed () {

app.on('activate', function activate () {
if (player.win === null) {
al.recall()
player.init()
}
globalShortcuts.reregister()
Expand Down
3 changes: 2 additions & 1 deletion renderer/elements/player/progress.js
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,10 @@ class Progress extends Component {

update (state, emit) {
this.emit = emit
if (this.disabled !== truthy(state.player.currentIndex)) return true
if (this.key !== get(state, 'player.currentTrack.key')) return true
if (this.position !== state.player.currentTime) return true
if (this.disabled !== truthy(state.player.currentIndex)) return true
if (this.duration !== get(state, 'player.currentTrack.duration')) return true
return false
}
}
Expand Down
2 changes: 1 addition & 1 deletion renderer/elements/playlist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class Playlist extends Component {

update (state, emit) {
if (this.loading !== state.library.loading) return true
if (this.trackView.update(state, emit)) return true
this.trackView.render(state, emit)
return false
}
}
Expand Down
2 changes: 1 addition & 1 deletion renderer/elements/playlist/track-view.js
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ class TrackView extends Component {
if (this.isNewQuery !== state.library.isNewQuery) return true
if (shouldColumnsUpdate(this.columns, state.library.columns)) return true
// Mutate
if (this.currentIndex !== state.library.currentIndex) {
if (this.currentIndex !== state.library.currentIndex && !this.isNewQuery) {
this.mutateCurrentIndex(state.library.currentIndex)
}
if (this.selectedIndex !== state.library.selectedIndex) {
Expand Down
4 changes: 2 additions & 2 deletions renderer/stores/library.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ function getInitialState () {
currentIndex: mainState.al.index,
search: mainState.al.searchTerm,
selectedIndex: null,
isNewQuery: false,
loading: false,
isNewQuery: mainState.al.isNewQuery,
loading: mainState.loading,
columns: Array.from(COLUMNS).reduce((obj, col) => {
obj[col] = true
return obj
Expand Down

0 comments on commit eb93a40

Please sign in to comment.