Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uid problem (issues/365) #377

Closed
wants to merge 2 commits into from
Closed

Fix uid problem (issues/365) #377

wants to merge 2 commits into from

Conversation

jchiu0
Copy link
Contributor

@jchiu0 jchiu0 commented Dec 12, 2016

#365


This change is Reviewable

@jchiu0 jchiu0 changed the title Fix issues/365 Fix uid problem (issues/365) Dec 12, 2016
@manishrjain
Copy link
Contributor

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@pawanrawal
Copy link
Contributor

:lgtm:


Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


query/query.go, line 243 at r1 (raw file):

				uc := dst.New(pc.Attr)

				// Doing check for UID here is no good because some of these might be

I guess we can remove this stuff now?


Comments from Reviewable

@jchiu0 jchiu0 closed this Dec 14, 2016
@jchiu0 jchiu0 deleted the fix/uid branch December 14, 2016 04:34
arijitAD pushed a commit that referenced this pull request Oct 15, 2020
Implementing ConsensusMessage and adding tests
Update Encode type byte to ConsensusMsgType (Eid consensus engine unique identifier to []byte, 4)
Add new funcs to types.ConsensusEngineID to facilitate type management
Add comments to all new/updated functions
Update BabeEngineId to BabeEngineID in all places and fix minor typo
Update comments
Add tests & increase test coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants