Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit Logs timestamp bug #59

Closed
manishrjain opened this issue Mar 8, 2016 · 2 comments
Closed

Commit Logs timestamp bug #59

manishrjain opened this issue Mar 8, 2016 · 2 comments
Labels
kind/bug Something is broken.
Milestone
v0.3

Comments

@manishrjain
Copy link
Contributor

manishrjain commented Mar 8, 2016 •
edited
Loading

Commit Logs require monotonically increasing timestamps. Currently, if the clock moves back in time, the logs would cause a log FATAL. We should instead just wait to let the timestamp increase above the last valid ts; instead of crashing.
@manishrjain manishrjain added the kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. label Mar 8, 2016
@manishrjain manishrjain added this to the v0.3 milestone Mar 8, 2016
@manishrjain
Copy link
Contributor Author

Commit log time-stamp

@manishrjain manishrjain added kind/bug Something is broken. and removed kind/maintenance Maintenance tasks, such as refactoring, with no impact in features. labels Apr 28, 2016
@manishrjain
Copy link
Contributor Author

This has been resolved.

janardhan1993 pushed a commit that referenced this issue Jun 26, 2017
@zaibon @manishrjain
allow to put value log in another folder then the rest of the files (#59
a40aa02 
)
@manishrjain manishrjain added the kind/bug Something is broken. label Mar 21, 2018
arijitAD pushed a commit that referenced this issue Oct 15, 2020
@amerameen @noot
Amer/encode strings (#59)
f068b79 
* added support for strings in encodeTests and added preliminary string tests

* added string tests for mode = 1 and mode = 2. mode = 3 test commented out because num_bytes_n = 3 results in a negative number for num_bytes_n - 4

* Refactor string tests. Create seperate function for setup of tests.

* Changed TestEncode so it doesn't try to print a very long string upon a failed test

* Added test for special characters

* Commented out long running test (testString3)

* Fixed issue that caused linter to fail CI

* Added in comment on long running test being omitted for the CI and uncommented a test that was accidentilly commented out
shivaji-kharse pushed a commit that referenced this issue Mar 12, 2024
@billprovince
feat(indexing): Adopting GenericOpts and templated VectorIndex. (#59)
160a0fa 
Description: Pulls in changes from vector-indexer that allow us to
specify configuration options when creating a VectorIndex. This will
allow us (for example) to specify the metric type for the vector index
(euclidian vs dotproduct vs cosine) separate from the technology for the
index type (hnsw vs vamana vs kdtree vs hypertree).

Note that at the moment, the process still retains everything using
float64 arrays, even though we want to switch to float32. We will take
this in two steps to keep the relative sizes of the changes a bit more
reasonable.

Closes: Hyp-14
harshil-goel pushed a commit that referenced this issue Mar 12, 2024
@billprovince
feat(indexing): Adopting GenericOpts and templated VectorIndex. (#59)
bcdd60b 
Description: Pulls in changes from vector-indexer that allow us to
specify configuration options when creating a VectorIndex. This will
allow us (for example) to specify the metric type for the vector index
(euclidian vs dotproduct vs cosine) separate from the technology for the
index type (hnsw vs vamana vs kdtree vs hypertree).

Note that at the moment, the process still retains everything using
float64 arrays, even though we want to switch to float32. We will take
this in two steps to keep the relative sizes of the changes a bit more
reasonable.

Closes: Hyp-14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something is broken.
Milestone
v0.3
Development

No branches or pull requests
1 participant
@manishrjain