Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uids() logic is now O(mn) instead of O(m+n) #576

Closed
jchiu255 opened this issue Feb 12, 2017 · 1 comment
Closed

Uids() logic is now O(mn) instead of O(m+n) #576

jchiu255 opened this issue Feb 12, 2017 · 1 comment
Assignees
@jchiu255
Labels
kind/bug Something is broken.

Comments

@jchiu255
Copy link
Contributor

jchiu255 commented Feb 12, 2017 •
edited by manishrjain
Loading

https://github.com/dgraph-io/dgraph/blob/master/posting/list.go#L574

We should not create a new iterator in each l.iterate call, if we assume that both lists are sorted.

There might be some other instances of this somewhere else.
@jchiu255 jchiu255 self-assigned this Feb 12, 2017
@jchiu255 jchiu255 added the kind/bug Something is broken. label Feb 12, 2017
@jchiu255
Copy link
Contributor Author

Took a look at 3ca38ad#diff-f5b1e11a19c25b553a4f15d3ef4594f6R137.

I found no other problems so far. I will commit a simple fix.

@manishrjain manishrjain added the kind/bug Something is broken. label Mar 21, 2018
arijitAD pushed a commit that referenced this issue Oct 15, 2020
@noot
consensus/babe, core: initialize new babe session for each epoch (#576)
c99580d 
* add done channel between babe and core, when epoch complete, done is signalled and core creates the next epoch's babe session
* slightly modify build block logic to conform to spec (we are supposed to pass in a new header to initialize_block, not the parent header)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchiu255 jchiu255

Labels
kind/bug Something is broken.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manishrjain @jchiu255