Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misspell warnings. #986

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Fix misspell warnings. #986

merged 1 commit into from
Aug 19, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Aug 16, 2019

This change is Reviewable

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


@martinmr you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 Message
The description of this pull request is blank. Adding a high-level summary will help our reviewers provide better feedback.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a once-over to make sure all of the instances were caught. PullRequest has an internal tool visible on this side similar to misspell and it didn't fire off any warnings/errors.

Minor nitpick:
Consider updating the top of file copyright years to 2019. Obviously not needed for this PR, though.


Reviewed with ❤️ by PullRequest

@@ -836,7 +836,7 @@ func BenchmarkRandomRead(b *testing.B) {

func getTableForBenchmarks(b *testing.B, count int) *Table {
rand.Seed(time.Now().Unix())
opts := Options{BlockSize: 4 * 1024, BloomFalsePostive: 0.01}
opts := Options{BlockSize: 4 * 1024, BloomFalsePositive: 0.01}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These happen to the best of us.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, I hope it was not difficult to track down.


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✖️ This code review was cancelled. See Details

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @manishrjain, and @martinmr)

Copy link
Contributor

@ashish-goswami ashish-goswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @manishrjain, and @martinmr)

@martinmr martinmr merged commit 6a7fb6c into master Aug 19, 2019
@martinmr martinmr deleted the martinmr/fix-misspell branch August 19, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants