Update master.yml #170
Open
Update master.yml #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./ci.sh Compatibility Warning Configuration Update: I have preserved the original ci.sh script but added shell: bash to the workflow configuration to ensure it executes correctly on Windows runners (which default to PowerShell). Potential Risk: Please be aware that using bash on Windows does not emulate a full Linux environment. If ci.sh contains Linux-specific commands (e.g., apt-get) or absolute paths (e.g., /etc/...), the Windows job will fail. Safe Execution: If the script strictly executes platform-agnostic commands—such as cargo fmt, cargo clippy, and cargo test—it will run successfully across all platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./ci.sh Compatibility Warning
Configuration Update: I have preserved the original ci.sh script but added shell: bash to the workflow configuration to ensure it executes correctly on Windows runners (which default to PowerShell).
Potential Risk: Please be aware that using bash on Windows does not emulate a full Linux environment. If ci.sh contains Linux-specific commands (e.g., apt-get) or absolute paths (e.g., /etc/...), the Windows job will fail.
Safe Execution: If the script strictly executes platform-agnostic commands—such as cargo fmt, cargo clippy, and cargo test—it will run successfully across all platforms.