Adding FFI functions for Hyperlight Guest CAPI #937

vshailesh · 2025-10-06T20:28:59Z

closes Missing hl_get_host_return_value_as_* #274
Added function for bool, f32, f64, string, vecbytes
Added tests for bool, f32, f64, string

…le, string, vecbytes Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

vshailesh · 2025-10-06T20:31:12Z

@ludfjig
I added test for bool and string, and they pass on my local builds.
But tests for f32 and f64 fail, and the values getting returned is some garbage value, maybe because of overflow. I am not sure.

Please review the test cases, and tell me if I have missed something

src/hyperlight_host/tests/integration_test.rs

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

dblnz

Thanks for your contribution!
It looks good from my point of view.
Let's see what CI says 😄 I've triggered the builds.

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.37.1 to 1.37.2. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.37.1...v1.37.2) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.37.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [windows-sys](https://github.com/microsoft/windows-rs) from 0.61.1 to 0.61.2. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](https://github.com/microsoft/windows-rs/commits) --- updated-dependencies: - dependency-name: windows-sys dependency-version: 0.61.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

ludfjig · 2025-10-07T16:29:21Z

Clippy has a couple of complaints, otherwise looks good to me. For the #[ignore] you added, would you mind putting a small comment about why, and linking the issue #179.

BTW when you want to update branch because it's out of date, I recommend using git rebase main, so the commits will not show up on this branch, instead of using something like git merge which will explicitly put the commits on the branch

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.37.2 to 1.38.0. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.37.2...v1.38.0) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.38.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

vshailesh · 2025-10-07T20:50:22Z

implemented the clippy suggested changes and added comments for ignore attribute

Bumps [windows-result](https://github.com/microsoft/windows-rs) from 0.4.0 to 0.4.1. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](https://github.com/microsoft/windows-rs/commits) --- updated-dependencies: - dependency-name: windows-result dependency-version: 0.4.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [windows-version](https://github.com/microsoft/windows-rs) from 0.1.6 to 0.1.7. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](https://github.com/microsoft/windows-rs/commits) --- updated-dependencies: - dependency-name: windows-version dependency-version: 0.1.7 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

dblnz · 2025-10-08T12:44:25Z

Because of other work merged into main, now there are conflicts with this PR.
Please rebase on the latest main and fix the conflicts.

Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.38.0 to 1.38.1. - [Release notes](https://github.com/crate-ci/typos/releases) - [Changelog](https://github.com/crate-ci/typos/blob/master/CHANGELOG.md) - [Commits](crate-ci/typos@v1.38.0...v1.38.1) --- updated-dependencies: - dependency-name: crate-ci/typos dependency-version: 1.38.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add test that fails due memory leaking when host function error occurs Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Update FlatBuffer schema and generation process - Add all.fbs to include all schema files in one place - Restructure function_call_result.fbs to use Result-like union - Add HostError variant to ErrorCode enum in guest_error.fbs - Update flatbuffer generation command in Justfile to use all.fbs - Update documentation for new generation process Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Regenerate FlatBuffer generated code Update all generated Rust code based on the new schema definitions. This includes new types for error handling and result structures. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Refactor error handling types and utilities - Update function_types.rs to handle Result-like return values - Simplify guest_error.rs wrapper implementation - Update util.rs for new generated types - Update mod.rs for new generated types Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Remove obsolete guest error handling - Remove guest_err.rs from hyperlight_host (replaced by new error handling) - Remove guest_err.rs from hyperlight_guest_bin (replaced by new error handling) - Update func/mod.rs to remove obsolete import Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Update host-side error handling - Update initialized_multi_use.rs to use new Result-like error handling - Update mem/mgr.rs to handle host function errors properly - Update sandbox/outb.rs for new error propagation pattern Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Update guest-side error handling - Update guest/host_comm.rs to use new Result-like return values - Update guest_bin/call.rs to properly handle host function errors - Update guest_bin/lib.rs to remove obsolete error handling import and make GUEST_HANDLE public (for use in C-API) - Update guest_capi/error.rs to support new error types Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Fix up test to work with new error handling Update sandbox_host_tests.rs to use the new Result-like error handling pattern. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Update Cargo dependencies Update Cargo.lock and Cargo.toml files to reflect the dependency changes needed for the new error handling implementation. Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Fix test so it passes Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * First round of PR feedback Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Unignore forgotten test Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> * Update flatc version in docs Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com> --------- Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>

Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>

Bumps [wasmparser](https://github.com/bytecodealliance/wasm-tools) from 0.239.0 to 0.240.0. - [Release notes](https://github.com/bytecodealliance/wasm-tools/releases) - [Commits](https://github.com/bytecodealliance/wasm-tools/commits) --- updated-dependencies: - dependency-name: wasmparser dependency-version: 0.240.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [windows](https://github.com/microsoft/windows-rs) from 0.62.1 to 0.62.2. - [Release notes](https://github.com/microsoft/windows-rs/releases) - [Commits](https://github.com/microsoft/windows-rs/commits) --- updated-dependencies: - dependency-name: windows dependency-version: 0.62.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

vshailesh added 11 commits October 6, 2025 13:59

Closes hyperlight-dev#274: Adding FFI functions for bool, float, doub…

b4c0313

…le, string, vecbytes Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

Adding Tests for CAPI flatbuffers

c0e5dfb

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

Corrected number of arguments in guest function

1f402f9

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

corrected return type in test cases, integration_test.rs

4a27841

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

corrected test case

2c1cea0

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

corrected test case

e66ce6e

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

corrected test cases

cfe2c62

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

corrected test cases

3c5acec

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

corrected test cases

ab379d7

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

format fix

24eb8cc

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

removed unnecessary imports

da42d0e

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

vshailesh requested review from danbugs, ludfjig, dblnz, devigned, syntactically, marosset, jprendes and simongdavies as code owners October 6, 2025 20:29

ludfjig requested changes Oct 6, 2025

View reviewed changes

src/hyperlight_host/tests/integration_test.rs Outdated Show resolved Hide resolved

Separate function for creating Uninitialized Sandbox in C-language

e77c24e

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

dblnz added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Oct 7, 2025

dblnz reviewed Oct 7, 2025

View reviewed changes

vshailesh and others added 3 commits October 7, 2025 16:58

resolve import errors

4450a0b

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

dependabot bot and others added 2 commits October 8, 2025 02:17

Documentation and integration_test fixes

a060875

Signed-off-by: Shailesh Vashishth <shavashishth@gmail.com>

dependabot bot added 2 commits October 8, 2025 10:30

vshailesh requested a review from ludfjig October 8, 2025 16:24

ludfjig and others added 4 commits October 9, 2025 15:23

Fix join github actions job (hyperlight-dev#944)

f66d987

Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>

vshailesh closed this Oct 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding FFI functions for Hyperlight Guest CAPI #937

Adding FFI functions for Hyperlight Guest CAPI #937

vshailesh commented Oct 6, 2025 •

edited

Loading

Uh oh!

vshailesh commented Oct 6, 2025 •

edited

Loading

Uh oh!

Uh oh!

dblnz left a comment

Uh oh!

ludfjig commented Oct 7, 2025 •

edited

Loading

Uh oh!

vshailesh commented Oct 7, 2025

Uh oh!

dblnz commented Oct 8, 2025

Uh oh!

Uh oh!

Adding FFI functions for Hyperlight Guest CAPI #937

Adding FFI functions for Hyperlight Guest CAPI #937

Conversation

vshailesh commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vshailesh commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dblnz left a comment

Choose a reason for hiding this comment

Uh oh!

ludfjig commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vshailesh commented Oct 7, 2025

Uh oh!

dblnz commented Oct 8, 2025

Uh oh!

Uh oh!

vshailesh commented Oct 6, 2025 •

edited

Loading

vshailesh commented Oct 6, 2025 •

edited

Loading

ludfjig commented Oct 7, 2025 •

edited

Loading