Remove version number from hyperlight-testing crate dependency #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simongdavies
requested review from
danbugs,
ludfjig,
dblnz,
devigned,
syntactically,
marosset and
jprendes
as code owners
simongdavies
force-pushed
the
fix-cargo-toml
branch
from
7157f18 to
f9ae1e7
Compare
|
I think we also need to remove the version.workspace = truefrom |
How come, I did a dry run publish and it worked |
|
#580 added the version to |
Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
force-pushed
the
fix-cargo-toml
branch
from
f9ae1e7 to
8b99315
Compare
simongdavies
added a commit
to simongdavies/hyperlight
that referenced
this pull request
Jun 9, 2025
…light-dev#588) Signed-off-by: Simon Davies <simongdavies@users.noreply.github.com>
simongdavies
added a commit
that referenced
this pull request
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #580 a version number was adding to the hyperlight-testing dependency. This caused the Cargo pubish job for the last release to fail.
This PR removes the version number so we don't have to publish the hyperlight-testing crate