[refactor] #1903: move event emission to modify_* methods

[Arjentix]

Description of the Change

• All WSV modify_ methods are now implemented through each other. New modify_world() is on top
• Introduce new strongly typed events
• modify_ methods accepts closures returning strongly typed event
• Refactor filters for strongly typed events

Issue

Resolves #1892

Benefits

• Events are emitted only in WSV
• Now there is no way to call modify_ method without event emitting
• Decreased chance to emit wrong event

TODO

• Fix failing tests
• Add documentation
• Rebase to the new iroha2-dev commits

[codecov]

Codecov Report

Merging #1931 (45e7fee) into iroha2-dev (9a149ee) will decrease coverage by 0.40%.
The diff coverage is 53.11%.

@@              Coverage Diff               @@
##           iroha2-dev    #1931      +/-   ##
==============================================
- Coverage       78.04%   77.63%   -0.41%     
==============================================
  Files             164      165       +1     
  Lines           22625    22907     +282     
==============================================
+ Hits            17657    17784     +127     
- Misses           4968     5123     +155     

Impacted Files	Coverage Δ
client_cli/src/main.rs	0.32% <0.00%> (ø)
core/src/smartcontracts/mod.rs	100.00% <ø> (ø)
data_model/src/lib.rs	49.03% <ø> (ø)
version/src/lib.rs	35.48% <0.00%> (ø)
data_model/src/events/data/filters.rs	25.20% <25.20%> (ø)
data_model/src/events/data/events.rs	31.66% <31.66%> (ø)
core/src/smartcontracts/isi/domain.rs	48.07% <54.41%> (+4.59%)	⬆️
core/src/smartcontracts/isi/world.rs	58.62% <60.86%> (+8.62%)	⬆️
core/src/smartcontracts/isi/account.rs	53.84% <61.90%> (+1.73%)	⬆️
core/src/smartcontracts/isi/mod.rs	73.63% <66.66%> (-0.36%)	⬇️
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a149ee...45e7fee. Read the comment docs.

[mversic]

I'm not sure this event should be called MetadataInserted. Maybe rather StoreInserted?

[mversic]

actually, I think there should be only 4 events something like:

pub enum AssetEvent {
    Created(AssetId),
    Deleted(AssetId),
    Added(AssetId),
    Removed(AssetId),
}

[Arjentix]

Then what events should be produced by SetKeyValue<Asset, Name, Value> and RemoveKeyValue<Asset, Name>?

[mversic]

As I see it, asset can be created, deleted, added a quantity or removed a quantity where quantity can be a number or key-value. SetKeyValue is adding a key value to asset which holds key-value entities

[mversic]

@Arjentix what happened with this? you just resolved the conversation without a comment

[Arjentix]

Sorry, I misunderstood your comment, I've read it as Ah I see it

So do you think, it should be Added and Removed for SetKeyValue and RemoveKeyValue? In this instructions code there are a lot of metadata terminology, is it okay then?

[mversic]

As I see it, asset can be created, deleted, added a quantity or removed a quantity where quantity can be a number or key-value. SetKeyValue is adding a key value to asset which holds key-value entities