[feature] #1898: share workdir as a volume with dev docker instances

[mversic]

Signed-off-by: Marin Veršić marin.versic101@gmail.com

Description of the Change

this should enable you to build on locally and deploy in docker if you build for x86_64-unknown-linux-gnu target. This may not always be the case because it links statically against glibc so there can arise version mismatch. In this case you can build for x86_64-unknown-linux-musl target which is links to libc statically

building in docker would bloat the container size so I haven't included cargo or rustc in the docker image, but you can install them if you find it easier to build inside docker

Issue

Closes #1898

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

[codecov]

Codecov Report

Merging #1910 (c3b4e6b) into iroha2-dev (2102df4) will decrease coverage by 0.55%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           iroha2-dev    #1910      +/-   ##
==============================================
- Coverage       78.26%   77.71%   -0.56%     
==============================================
  Files             164      164              
  Lines           22528    22528              
==============================================
- Hits            17631    17507     -124     
- Misses           4897     5021     +124     

Impacted Files	Coverage Δ
core/src/sumeragi/mod.rs	77.69% <0.00%> (-8.08%)	⬇️
core/src/sumeragi/view_change.rs	91.81% <0.00%> (-6.04%)	⬇️
core/src/sumeragi/network_topology.rs	91.11% <0.00%> (-5.28%)	⬇️
crypto/src/signature.rs	83.05% <0.00%> (-1.70%)	⬇️
p2p/src/peer.rs	82.48% <0.00%> (-0.89%)	⬇️
actor/src/lib.rs	89.07% <0.00%> (-0.35%)	⬇️
data_model/src/expression.rs	70.77% <0.00%> (-0.27%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2102df4...c3b4e6b. Read the comment docs.

[s8sato]

Could you explain why this flag is necessary?

[mversic]

There is no init system in docker and therefore, first process that is executed (./iroha in our case) gets PID = 1. This PID is special because it ignores signals sent to it like SIGKILL or SIGTERM. You can see this if you try to kill the process from inside container(and you cannot) or you can see that running docker stop takes 10sec to complete because it waits on graceful shutdown which isn't happening.

This can be resolved in two ways, either by adding small init system called tini which is packed with docker or explicit signal handling needs to be included in the iroha binary(I haven't confirmed this)

[appetrosyan]

Explicit signal handling is planned after #1480. With that said, we don't gracefully exit regardless, so the implicit signal handling is fine for now.

[s8sato]

The local repository path varies by developer though

[mversic]

Yes, they vary. That is why .(current dir) is mapped to /root/soramitsu/iroha in container. It doesn't need to be mapped, I needed a way to copy locally built iroha into docker container and run it. I can get away with docker cp but maybe someone would like to build iroha inside container and now they have the possibility with shared volume

[s8sato]

I mistook right for left of :

[s8sato]

I mistook right for left of :