[feature] #1606: Add ipfs link to domain logo in Domain structure #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arjentix
requested review from
appetrosyan,
mversic and
s8sato
as code owners
github-actions
bot
added
the
iroha2-dev
Arjentix
changed the title
Arjentix
changed the title
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1886 +/- ##
===========================================
Coverage 78.66% 78.67%
===========================================
Files 156 156
Lines 22140 22227 +87
===========================================
+ Hits 17417 17486 +69
- Misses 4723 4741 +18
Continue to review full report at Codecov.
|
appetrosyan
reviewed
Feb 9, 2022
appetrosyan
suggested changes
Feb 9, 2022
appetrosyan
previously approved these changes
Feb 9, 2022
mversic
requested changes
Feb 9, 2022
mversic
reviewed
Feb 10, 2022
data_model/src/lib.rs
Outdated
| let _domain = Domain { | ||
| logo: Some(logo), | ||
| ..Domain::test("sora") | ||
| }; |
There was a problem hiding this comment.
there are no assertions in the test? does it test anything?
There was a problem hiding this comment.
Well, it just an example of usage with logo. But I'm agree, looks strange. I'm gonna remove it
appetrosyan
previously approved these changes
Feb 10, 2022
mversic
previously approved these changes
Feb 10, 2022
…ructure Signed-off-by: Arjentix <arjentix@gmail.com>
Arjentix
force-pushed
the
add_logo_link_into_domain
branch
from
675913b
to
9547d20
Compare
mversic
approved these changes
Feb 10, 2022
appetrosyan
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add new field into Domain structure. Field represents IPFS link into Domain logo.
Add
IpfsPathstructure to superficially validate pathI haven't find good IPFS paths specifications, so I was inspiring these realisations:
Issue
Resolves #1606
Benefits
Now domains can have logo
Possible Drawbacks
IPFS paths isn't fully validated. Full validation requires hash decoding and possible requesting IPFS system to check, if image really exists.
Checkout #1885
Usage Examples or Tests [optional]
See
client/integration_tests/add_domain.rs