Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #1811: added tests and checks to dedup trusted peer keys. #1844

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

appetrosyan
Copy link
Contributor

Description of the Change

Added more sanity checks to the configuration reading process.

Issue

Closes #1811

Benefits

More safety.

Possible Drawbacks

The configuration.json file is read twice.

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #1844 (fdf0c26) into iroha2-dev (204163b) will increase coverage by 0.37%.
The diff coverage is 95.16%.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1844      +/-   ##
==============================================
+ Coverage       78.10%   78.47%   +0.37%     
==============================================
  Files             148      148              
  Lines           21511    21555      +44     
==============================================
+ Hits            16801    16916     +115     
+ Misses           4710     4639      -71     
Impacted Files Coverage Δ
core/src/sumeragi/mod.rs 85.21% <92.30%> (+3.67%) ⬆️
core/src/config.rs 100.00% <100.00%> (+4.65%) ⬆️
crypto/src/lib.rs 83.02% <100.00%> (+0.32%) ⬆️
core/src/block_sync.rs 88.67% <0.00%> (-1.26%) ⬇️
p2p/src/peer.rs 82.26% <0.00%> (-0.89%) ⬇️
data_model/src/expression.rs 70.77% <0.00%> (-0.27%) ⬇️
data_model/src/lib.rs 69.14% <0.00%> (+0.36%) ⬆️
core/src/sumeragi/network_topology.rs 95.83% <0.00%> (+4.16%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204163b...fdf0c26. Read the comment docs.

core/src/config.rs Show resolved Hide resolved
core/src/config.rs Outdated Show resolved Hide resolved
@appetrosyan appetrosyan marked this pull request as draft January 26, 2022 09:14
@appetrosyan appetrosyan force-pushed the i2-warn-duplicate branch 2 times, most recently from 0ba43bd to faf46ff Compare January 27, 2022 07:27
@appetrosyan appetrosyan marked this pull request as ready for review January 27, 2022 07:41
mversic
mversic previously approved these changes Jan 27, 2022
…keys.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan merged commit 53bd9d0 into hyperledger:iroha2-dev Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants