Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #1754: Add Kura inspector CLI #1817

Merged
merged 3 commits into from
Jan 31, 2022

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Jan 17, 2022

Description of the Change

Add a CLI tool to inspect the disk storage

2022-01-31T221621+090000

Issue

Closes #1754

Benefits

Now we can inspect the disk storage regardless of the operating status of Iroha

Possible Drawbacks

None

Usage Examples or Tests

  • kura_inspector print prints the latest block
    • Tested by kura_inspector::print::tests::test_print_default
  • kura_inspector -f 100 print -n 5 prints every block, if exists, whose height is between 100 and 104
    • Tested by kura_inspector::print::tests::test_print_range
  • kura_inspector -f 100 print -n 5 >/dev/null same as above, but prints only block read errors

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #1817 (cd2cfcb) into iroha2-dev (fe475bc) will decrease coverage by 0.61%.
The diff coverage is 70.28%.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1817      +/-   ##
==============================================
- Coverage       78.41%   77.80%   -0.62%     
==============================================
  Files             152      155       +3     
  Lines           21700    21875     +175     
==============================================
+ Hits            17017    17019       +2     
- Misses           4683     4856     +173     
Impacted Files Coverage Δ
core/src/block.rs 90.72% <ø> (+0.66%) ⬆️
tools/kura_inspector/src/lib.rs 3.44% <3.44%> (ø)
tools/kura_inspector/src/main.rs 4.76% <4.76%> (ø)
tools/kura_inspector/src/print.rs 96.80% <96.80%> (ø)
core/src/sumeragi/mod.rs 76.91% <0.00%> (-8.79%) ⬇️
core/src/sumeragi/view_change.rs 91.81% <0.00%> (-6.04%) ⬇️
core/src/sumeragi/network_topology.rs 91.11% <0.00%> (-4.73%) ⬇️
crypto/src/signature.rs 84.06% <0.00%> (-2.00%) ⬇️
client/src/http_client.rs 94.68% <0.00%> (-1.07%) ⬇️
p2p/src/peer.rs 82.26% <0.00%> (-0.67%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe475bc...cd2cfcb. Read the comment docs.

@appetrosyan appetrosyan added the Enhancement New feature or request label Jan 27, 2022
@s8sato s8sato force-pushed the feat/1754 branch 2 times, most recently from 4658102 to bc4ddd1 Compare January 30, 2022 07:45
@s8sato s8sato marked this pull request as ready for review January 30, 2022 08:35
@s8sato s8sato linked an issue Jan 30, 2022 that may be closed by this pull request
appetrosyan
appetrosyan previously approved these changes Jan 30, 2022
appetrosyan
appetrosyan previously approved these changes Jan 31, 2022
tools/kura_inspector/src/print.rs Outdated Show resolved Hide resolved
tools/kura_inspector/src/print.rs Outdated Show resolved Hide resolved
tools/kura_inspector/src/print.rs Outdated Show resolved Hide resolved
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato merged commit b23b43e into hyperledger:iroha2-dev Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI tool to inspect blocks from disk storage
3 participants