Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #1783: Fixed torii benchmark. #1784

Merged
merged 3 commits into from
Jan 10, 2022

Conversation

appetrosyan
Copy link
Contributor

Signed-off-by: Aleksandr a-p-petrosyan@yandex.ru

Description of the Change

Fixes the benchmarks.

Issue

Closes #1783

Benefits

Benchmarks work

Possible Drawbacks

None

Usage Examples or Tests [optional]

cd client
cargo bench

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jan 6, 2022
mversic
mversic previously approved these changes Jan 6, 2022
client/benches/torii.rs Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1784 (545ddc3) into iroha2-dev (d7c0b58) will increase coverage by 0.41%.
The diff coverage is 2.38%.

❗ Current head 545ddc3 differs from pull request most recent head a34dd3b. Consider uploading reports for the commit a34dd3b to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1784      +/-   ##
==============================================
+ Coverage       77.42%   77.84%   +0.41%     
==============================================
  Files             136      137       +1     
  Lines           21047    21089      +42     
==============================================
+ Hits            16296    16417     +121     
+ Misses           4751     4672      -79     
Impacted Files Coverage Δ
client/tests/million_accounts.rs 2.38% <2.38%> (ø)
p2p/src/peer.rs 82.26% <0.00%> (+0.22%) ⬆️
core/src/block_sync.rs 90.56% <0.00%> (+1.25%) ⬆️
core/src/sumeragi/network_topology.rs 96.11% <0.00%> (+5.00%) ⬆️
core/src/sumeragi/view_change.rs 97.85% <0.00%> (+7.29%) ⬆️
core/src/sumeragi/mod.rs 85.01% <0.00%> (+8.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c0b58...a34dd3b. Read the comment docs.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
client/benches/torii.rs Show resolved Hide resolved
client/benches/torii.rs Show resolved Hide resolved
client/tests/million_accounts.rs Outdated Show resolved Hide resolved
mversic
mversic previously approved these changes Jan 10, 2022
mversic
mversic previously approved these changes Jan 10, 2022
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@mversic mversic self-requested a review January 10, 2022 09:17
@appetrosyan appetrosyan merged commit 98ee674 into hyperledger:iroha2-dev Jan 10, 2022
@appetrosyan appetrosyan deleted the i2-10m-benchmark branch January 10, 2022 10:00
appetrosyan added a commit that referenced this pull request Jan 10, 2022
@appetrosyan appetrosyan restored the i2-10m-benchmark branch January 10, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants