Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #1755: Minor fixes for #1743, #1725 #1760

Merged
merged 3 commits into from
Dec 28, 2021

Conversation

s8sato
Copy link
Contributor

@s8sato s8sato commented Dec 28, 2021

Description of the Change

Issue

Close #1755

Benefits

Possible Drawbacks

Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 28, 2021
Copy link
Contributor

@e-ivkov e-ivkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status naming is ok. As far as I understand that's what we agreed with DevOps on.

@s8sato
Copy link
Contributor Author

s8sato commented Dec 28, 2021

Ok, I'll revert to status term then

@s8sato s8sato closed this Dec 28, 2021
@s8sato s8sato reopened this Dec 28, 2021
@codecov
Copy link

codecov bot commented Dec 28, 2021

Codecov Report

Merging #1760 (36c86d6) into iroha2-dev (7df0caa) will increase coverage by 0.58%.
The diff coverage is 80.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1760      +/-   ##
==============================================
+ Coverage       77.11%   77.70%   +0.58%     
==============================================
  Files             132      132              
  Lines           20480    20480              
==============================================
+ Hits            15794    15913     +119     
+ Misses           4686     4567     -119     
Impacted Files Coverage Δ
...tests/integration_tests/multiple_blocks_created.rs 0.00% <0.00%> (ø)
client/tests/integration_tests/unstable_network.rs 0.00% <0.00%> (ø)
core/src/torii/mod.rs 77.54% <0.00%> (ø)
client/src/client.rs 76.96% <75.00%> (ø)
core/test_network/src/lib.rs 79.50% <85.00%> (ø)
client/src/config.rs 70.00% <100.00%> (ø)
...lient/tests/integration_tests/asset_propagation.rs 100.00% <100.00%> (ø)
client/tests/integration_tests/connected_peers.rs 90.69% <100.00%> (ø)
client/tests/integration_tests/events.rs 100.00% <100.00%> (ø)
.../tests/integration_tests/multisignature_account.rs 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df0caa...36c86d6. Read the comment docs.

@e-ivkov
Copy link
Contributor

e-ivkov commented Dec 28, 2021

Ok, we discussed at the status. Changing the URL naming from status to telemetry is ok here.

@s8sato s8sato marked this pull request as ready for review December 28, 2021 08:21
@s8sato s8sato changed the title [fix] #1755: Fix JSONs according to #1743 Domain struct change [fix] #1755: Minor fixes for #1743, #1725 Dec 28, 2021
mversic
mversic previously approved these changes Dec 28, 2021
@s8sato s8sato marked this pull request as draft December 28, 2021 08:40
appetrosyan
appetrosyan previously approved these changes Dec 28, 2021
e-ivkov
e-ivkov previously approved these changes Dec 28, 2021
Signed-off-by: s8sato <49983831+s8sato@users.noreply.github.com>
@s8sato s8sato dismissed stale reviews from e-ivkov, appetrosyan, and mversic via 36c86d6 December 28, 2021 08:48
@s8sato s8sato marked this pull request as ready for review December 28, 2021 08:48
@s8sato s8sato merged commit 3d85d89 into hyperledger:iroha2-dev Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants