Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] #1179: Add revoke-permission-or-role instruction #1748

Merged
merged 2 commits into from
Jan 12, 2022
Merged

[feature] #1179: Add revoke-permission-or-role instruction #1748

merged 2 commits into from
Jan 12, 2022

Conversation

appetrosyan
Copy link
Contributor

Signed-off-by: Aleksandr a-p-petrosyan@yandex.ru

[feature] #1179: Add revoke instruction.

Signed-off-by: Aleksandr a-p-petrosyan@yandex.ru

Description of the Change

  • Introduced Revoke isi.
  • Introduced RevokeBox implementations.
  • introduced very basic permissions validators for said Revoke isi.
  • Re-organised the permissions-validators crate

Issue

Closes #1179.

Benefits

  • Can revoked granted permissions.
  • permissions validators crate is much easier to navigate.

Possible Drawbacks

None

Usage Examples or Tests [optional]

TODO.

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 23, 2021
@appetrosyan appetrosyan added api-changes Changes in the API for client libraries Enhancement New feature or request labels Dec 23, 2021
@codecov
Copy link

codecov bot commented Dec 23, 2021 •
edited
Loading

Codecov Report

Merging #1748 (17e9921) into iroha2-dev (79d0df6) will decrease coverage by 0.26%.
The diff coverage is 61.24%.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1748      +/-   ##
==============================================
- Coverage       78.79%   78.53%   -0.27%     
==============================================
  Files             137      146       +9     
  Lines           21166    21218      +52     
==============================================
- Hits            16678    16663      -15     
- Misses           4488     4555      +67
Impacted Files Coverage Δ
config/src/lib.rs 16.66% <ø> (ø)
core/src/smartcontracts/isi/account.rs 35.59% <0.00%> (-3.30%) ⬇️
core/src/smartcontracts/isi/mod.rs 73.99% <0.00%> (-1.36%) ⬇️
core/src/smartcontracts/isi/permissions.rs 74.28% <0.00%> (-2.35%) ⬇️
core/src/wsv.rs 90.13% <ø> (ø)
data_model/src/events/data.rs 52.96% <0.00%> (-0.74%) ⬇️
data_model/src/lib.rs 69.11% <ø> (ø)
data_model/src/query.rs 33.24% <ø> (ø)
data_model/src/transaction.rs 60.72% <0.00%> (-0.23%) ⬇️
permissions_validators/src/lib.rs 75.00% <ø> (+10.64%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79d0df6...17e9921. Read the comment docs.

@appetrosyan appetrosyan self-assigned this Dec 27, 2021
@appetrosyan appetrosyan marked this pull request as ready for review January 10, 2022 06:40
@appetrosyan appetrosyan force-pushed the i2-revoke branch 3 times, most recently from a2908e2 to f5d87e9 Compare January 10, 2022 11:25
mversic
mversic previously approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@mversic mversic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you restructured this crate

core/src/smartcontracts/isi/account.rs Outdated Show resolved Hide resolved
core/src/smartcontracts/isi/account.rs Outdated Show resolved Hide resolved
@appetrosyan appetrosyan force-pushed the i2-revoke branch 2 times, most recently from c03997f to 6474845 Compare January 11, 2022 07:13
@mversic mversic self-requested a review January 11, 2022 07:51
mversic
mversic previously approved these changes Jan 11, 2022
View reviewed changes
s8sato
s8sato previously approved these changes Jan 12, 2022
View reviewed changes
@appetrosyan appetrosyan dismissed stale reviews from s8sato and mversic via a9fb849 January 12, 2022 08:05
@appetrosyan
[feature] hyperledger#1179: Add revoke-permission-or-role instruction
b5e6efe 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

[feature] hyperledger#1179: Add revoke instruction.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@appetrosyan
Doc fix.
17e9921 
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan merged commit 0a82112 into hyperledger:iroha2-dev Jan 12, 2022
@appetrosyan appetrosyan deleted the i2-revoke branch January 12, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mversic mversic mversic approved these changes

@s8sato s8sato s8sato approved these changes

@KalitaAlexey KalitaAlexey Awaiting requested review from KalitaAlexey

Assignees

@appetrosyan appetrosyan

Labels
api-changes Changes in the API for client libraries Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@appetrosyan @mversic @s8sato