-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #1689: Fix feature dependencies. #1688
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appetrosyan
requested review from
e-ivkov,
KalitaAlexey,
mversic and
s8sato
as code owners
December 6, 2021 13:38
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Dec 6, 2021
appetrosyan
force-pushed
the
i2-ci-fix
branch
from
December 6, 2021 13:43
3ffd13e
to
f3d4868
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1688 +/- ##
==============================================
- Coverage 77.16% 77.10% -0.06%
==============================================
Files 127 127
Lines 20308 20308
==============================================
- Hits 15670 15659 -11
- Misses 4638 4649 +11
Continue to review full report at Codecov.
|
appetrosyan
force-pushed
the
i2-ci-fix
branch
5 times, most recently
from
December 6, 2021 14:36
9ad1380
to
50e20b1
Compare
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan
force-pushed
the
i2-ci-fix
branch
from
December 6, 2021 14:47
50e20b1
to
ee91394
Compare
appetrosyan
changed the title
[feature] #1261: Add cargo bloat.
[feature] #1261, #1689: Add cargo bloat.
Dec 7, 2021
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan
force-pushed
the
i2-ci-fix
branch
from
December 7, 2021 05:37
8e8e46a
to
fccbf70
Compare
appetrosyan
changed the title
[feature] #1261, #1689: Add cargo bloat.
[feature] #1689: Fix feature dependencies.
Dec 7, 2021
s8sato
approved these changes
Dec 7, 2021
mversic
approved these changes
Dec 7, 2021
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
Dec 8, 2021
* [feature] hyperledger#1261: Add cargo bloat. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru> * Fixed compilation of individual packages. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
Dec 8, 2021
* [feature] hyperledger#1261: Add cargo bloat. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru> * Fixed compilation of individual packages. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan
added a commit
that referenced
this pull request
Dec 8, 2021
* Initial documentation of key_pairs. (#1684) Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru> * [feature] #1689: Fix feature dependencies. (#1688) * [feature] #1261: Add cargo bloat. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru> * Fixed compilation of individual packages. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru> * [fix] #1698: Fixed public keys, documentation and error messages. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
Dec 9, 2021
* [feature] hyperledger#1261: Add cargo bloat. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru> * Fixed compilation of individual packages. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan
added a commit
to appetrosyan/iroha
that referenced
this pull request
Dec 9, 2021
* [feature] hyperledger#1261: Add cargo bloat. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru> * Fixed compilation of individual packages. Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aleksandr a-p-petrosyan@yandex.ru
Description of the Change
Fixed feature dependencies.
Convinced myself that cargo bloat would be completely extraneous.
Issue
Closes #1689.
Benefits
Builds more reliable with the
-p
flag.Possible Drawbacks
None