Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #1689: Fix feature dependencies. #1688

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

appetrosyan
Copy link
Contributor

@appetrosyan appetrosyan commented Dec 6, 2021

Signed-off-by: Aleksandr a-p-petrosyan@yandex.ru

Description of the Change

Fixed feature dependencies.
Convinced myself that cargo bloat would be completely extraneous.

Issue

Closes #1689.

Benefits

Builds more reliable with the -p flag.

Possible Drawbacks

None

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 6, 2021
@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #1688 (fccbf70) into iroha2-dev (cd16272) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1688      +/-   ##
==============================================
- Coverage       77.16%   77.10%   -0.06%     
==============================================
  Files             127      127              
  Lines           20308    20308              
==============================================
- Hits            15670    15659      -11     
- Misses           4638     4649      +11     
Impacted Files Coverage Δ
core/src/sumeragi/mod.rs 87.44% <0.00%> (-1.27%) ⬇️
core/src/sumeragi/view_change.rs 97.45% <0.00%> (-0.43%) ⬇️
data_model/src/expression.rs 64.17% <0.00%> (-0.27%) ⬇️
core/src/sumeragi/network_topology.rs 95.12% <0.00%> (+0.25%) ⬆️
client/src/http_client.rs 96.80% <0.00%> (+1.06%) ⬆️
core/src/smartcontracts/isi/world.rs 69.23% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd16272...fccbf70. Read the comment docs.

@appetrosyan appetrosyan force-pushed the i2-ci-fix branch 5 times, most recently from 9ad1380 to 50e20b1 Compare December 6, 2021 14:36
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan changed the title [feature] #1261: Add cargo bloat. [feature] #1261, #1689: Add cargo bloat. Dec 7, 2021
Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
@appetrosyan appetrosyan changed the title [feature] #1261, #1689: Add cargo bloat. [feature] #1689: Fix feature dependencies. Dec 7, 2021
@appetrosyan appetrosyan merged commit 875ec52 into hyperledger:iroha2-dev Dec 7, 2021
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request Dec 8, 2021
* [feature] hyperledger#1261: Add cargo bloat.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

* Fixed compilation of individual packages.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request Dec 8, 2021
* [feature] hyperledger#1261: Add cargo bloat.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

* Fixed compilation of individual packages.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit that referenced this pull request Dec 8, 2021
* Initial documentation of key_pairs. (#1684)

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

* [feature] #1689: Fix feature dependencies. (#1688)

* [feature] #1261: Add cargo bloat.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

* Fixed compilation of individual packages.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

* [fix] #1698: Fixed public keys, documentation and error messages.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request Dec 9, 2021
* [feature] hyperledger#1261: Add cargo bloat.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

* Fixed compilation of individual packages.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
appetrosyan added a commit to appetrosyan/iroha that referenced this pull request Dec 9, 2021
* [feature] hyperledger#1261: Add cargo bloat.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

* Fixed compilation of individual packages.

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants