[ci] #1657: Update image to rust 1.57 #1666

appetrosyan · 2021-12-02T09:58:40Z

Signed-off-by: Aleksandr a-p-petrosyan@yandex.ru

Description of the Change

Made all cargo commands quiet to improve readability (this reduces the verbosity of test outputs, but still produces the full logs and messages for the failing tests).
Bump versions of nightly (2021-12-02 and stable (1.57) toolchains.

Issue

Closes #1657

Benefits

Better readability: no boilerplate messages should be present in the test output.
The check-pr-title workflow now accepts optional issues for some PR titles, as well as common abbreviations:

Possible Drawbacks

None found

Examples

[feat] #1666: refactor of CI runners
[docs]: CI
[ci]: Docs
[ci] #1330: not relevant feature, but can't check. 
[ci] #1630, #1637: This PR.

codecov · 2021-12-02T10:17:02Z

Codecov Report

Merging #1666 (c52f7b8) into iroha2-dev (c613d87) will increase coverage by 9.64%.
The diff coverage is 74.36%.

@@              Coverage Diff               @@
##           iroha2-dev    #1666      +/-   ##
==============================================
+ Coverage       67.63%   77.28%   +9.64%     
==============================================
  Files             128      128              
  Lines           23261    20467    -2794     
==============================================
+ Hits            15733    15817      +84     
+ Misses           7528     4650    -2878

Impacted Files	Coverage Δ
actor/src/lib.rs	`83.95% <ø> (ø)`
client/tests/integration_tests/add_account.rs	`100.00% <ø> (ø)`
client/tests/integration_tests/add_asset.rs	`100.00% <ø> (ø)`
client/tests/integration_tests/add_domain.rs	`100.00% <ø> (ø)`
...lient/tests/integration_tests/asset_propagation.rs	`100.00% <ø> (ø)`
client/tests/integration_tests/config.rs	`100.00% <ø> (ø)`
client/tests/integration_tests/events.rs	`98.92% <ø> (ø)`
...tests/integration_tests/multiple_blocks_created.rs	`0.00% <ø> (ø)`
.../tests/integration_tests/multisignature_account.rs	`100.00% <ø> (ø)`
...ts/integration_tests/multisignature_transaction.rs	`100.00% <ø> (ø)`
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 498bc56...c52f7b8. Read the comment docs.

.github/workflows/iroha2-dev-pr-title.yml

.github/workflows/iroha2-dev-pr-static.yml

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

.github/workflows/iroha2-add-label.yml

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

client/src/client.rs

config/derive/src/lib.rs

core/src/sumeragi/mod.rs

core/src/kura.rs

core/src/tx.rs

futures/tests/basic.rs

lints.toml

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

mversic · 2021-12-03T15:37:10Z

actor/src/lib.rs

 //! Iroha simple actor framework.
-//!
+#![allow(clippy::same_name_method)]


you can remove this

I'll keep it for the time being, if you ran cargo clippy -- -W clippy::same_name_method, it would exclude this file, but keep highlighting others.

github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 2, 2021

appetrosyan marked this pull request as ready for review December 2, 2021 10:32

appetrosyan requested review from e-ivkov, i1i1, KalitaAlexey, mversic and s8sato as code owners December 2, 2021 10:32

appetrosyan added CI Optimization Something isn't working as well as it should labels Dec 2, 2021

appetrosyan force-pushed the i2-ci-fix branch from 97b69fb to 05be42e Compare December 2, 2021 11:48

mversic reviewed Dec 2, 2021

View reviewed changes

.github/workflows/iroha2-dev-pr-title.yml Outdated Show resolved Hide resolved

.github/workflows/iroha2-dev-pr-static.yml Outdated Show resolved Hide resolved

appetrosyan force-pushed the i2-ci-fix branch 2 times, most recently from ecf7360 to a69ce24 Compare December 2, 2021 14:03

mversic previously approved these changes Dec 2, 2021

View reviewed changes

appetrosyan dismissed mversic’s stale review via fbd8d9f December 2, 2021 14:16

appetrosyan force-pushed the i2-ci-fix branch from a69ce24 to fbd8d9f Compare December 2, 2021 14:16

appetrosyan changed the title ~~[fix] #1630: Move back to self-hosted runners.~~ [fix] #(1630, 666): Move back to self-hosted runners. Dec 2, 2021

appetrosyan force-pushed the i2-ci-fix branch from fbd8d9f to b0b9d4d Compare December 2, 2021 14:17

appetrosyan changed the title ~~[fix] #(1630, 666): Move back to self-hosted runners.~~ [ci] #(1630, 666): Move back to self-hosted runners. Dec 2, 2021

appetrosyan force-pushed the i2-ci-fix branch from b0b9d4d to 14c40c2 Compare December 2, 2021 14:24

appetrosyan changed the title ~~[ci] #(1630, 666): Move back to self-hosted runners.~~ [fix] #(1630, 666): Move back to self-hosted runners. Dec 2, 2021

appetrosyan force-pushed the i2-ci-fix branch from 14c40c2 to 086b787 Compare December 2, 2021 14:27

appetrosyan changed the title ~~[fix] #(1630, 666): Move back to self-hosted runners.~~ [ci] #(1630, 666): Move back to self-hosted runners. Dec 2, 2021

appetrosyan force-pushed the i2-ci-fix branch from 086b787 to c4c1f1d Compare December 2, 2021 14:30

appetrosyan changed the title ~~[ci] #(1630, 666): Move back to self-hosted runners.~~ [fix] #(1630, 666): Move back to self-hosted runners. Dec 2, 2021

appetrosyan force-pushed the i2-ci-fix branch from c4c1f1d to 6dc92c6 Compare December 2, 2021 14:35

appetrosyan changed the title ~~[fix] #(1630, 666): Move back to self-hosted runners.~~ [ci] #(1630, 666): Move back to self-hosted runners. Dec 2, 2021

appetrosyan changed the title ~~[ci] #(1630, 666): Move back to self-hosted runners.~~ [Di] #(1630, 666): Move back to self-hosted runners. Dec 2, 2021

appetrosyan force-pushed the i2-ci-fix branch from 6dc92c6 to 7d15524 Compare December 2, 2021 14:41

appetrosyan changed the title ~~[fix] #1630, #1657: Move back to self-hosted runners.~~ [ci] #1630, #1657: Update image to rust 1.57 Dec 3, 2021

appetrosyan changed the title ~~[ci] #1630, #1657: Update image to rust 1.57~~ [ci] #1657: Update image to rust 1.57 Dec 3, 2021

appetrosyan added 4 commits December 3, 2021 12:10

[fix] hyperledger#1630: Move back to self-hosted runners.

d3a9045

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

More readable regex.

9e6f655

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

Created a workflow-based regex matcher.

9805986

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

Added bootstrap to push workflow.

ea08502

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

appetrosyan force-pushed the i2-ci-fix branch from 2a2791e to ea08502 Compare December 3, 2021 08:10

mversic previously approved these changes Dec 3, 2021

View reviewed changes

e-ivkov reviewed Dec 3, 2021

View reviewed changes

.github/workflows/iroha2-add-label.yml Outdated Show resolved Hide resolved

appetrosyan dismissed mversic’s stale review via 557991f December 3, 2021 12:16

Fixed new clippy lints.

6d63760

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

appetrosyan force-pushed the i2-ci-fix branch from 557991f to 6d63760 Compare December 3, 2021 12:16

appetrosyan commented Dec 3, 2021

View reviewed changes

client/src/client.rs Show resolved Hide resolved

e-ivkov reviewed Dec 3, 2021

View reviewed changes

config/derive/src/lib.rs Outdated Show resolved Hide resolved

core/src/sumeragi/mod.rs Outdated Show resolved Hide resolved

mversic reviewed Dec 3, 2021

View reviewed changes

core/src/kura.rs Outdated Show resolved Hide resolved

mversic reviewed Dec 3, 2021

View reviewed changes

core/src/kura.rs Outdated Show resolved Hide resolved

mversic reviewed Dec 3, 2021

View reviewed changes

core/src/tx.rs Show resolved Hide resolved

mversic reviewed Dec 3, 2021

View reviewed changes

futures/tests/basic.rs Show resolved Hide resolved

mversic reviewed Dec 3, 2021

View reviewed changes

lints.toml Show resolved Hide resolved

mversic self-requested a review December 3, 2021 13:07

Made trybuild tests pass.

cc5ddeb

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

e-ivkov previously approved these changes Dec 3, 2021

View reviewed changes

Removed cache from some jobs.

c52f7b8

Signed-off-by: Aleksandr <a-p-petrosyan@yandex.ru>

appetrosyan dismissed e-ivkov’s stale review via c52f7b8 December 3, 2021 15:27

appetrosyan changed the title ~~[ci] #1657: Update image to rust 1.57~~ DO NOT MERGE [ci] #1657: Update image to rust 1.57 Dec 3, 2021

mversic reviewed Dec 3, 2021

View reviewed changes

appetrosyan changed the title ~~DO NOT MERGE [ci] #1657: Update image to rust 1.57~~ [ci] #1657: Update image to rust 1.57 Dec 3, 2021

e-ivkov approved these changes Dec 3, 2021

View reviewed changes

mversic approved these changes Dec 3, 2021

View reviewed changes

appetrosyan merged commit 6cd608c into hyperledger:iroha2-dev Dec 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ci] #1657: Update image to rust 1.57 #1666

[ci] #1657: Update image to rust 1.57 #1666

appetrosyan commented Dec 2, 2021 •

edited by e-ivkov

Loading

codecov bot commented Dec 2, 2021 •

edited

Loading

mversic Dec 3, 2021

appetrosyan Dec 3, 2021

[ci] #1657: Update image to rust 1.57 #1666

[ci] #1657: Update image to rust 1.57 #1666

Conversation

appetrosyan commented Dec 2, 2021 • edited by e-ivkov Loading

Description of the Change

Issue

Benefits

Possible Drawbacks

Examples

codecov bot commented Dec 2, 2021 • edited Loading

Codecov Report

mversic Dec 3, 2021

Choose a reason for hiding this comment

appetrosyan Dec 3, 2021

Choose a reason for hiding this comment

appetrosyan commented Dec 2, 2021 •

edited by e-ivkov

Loading

codecov bot commented Dec 2, 2021 •

edited

Loading