-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] #1643: Wait for peers to commit genesis in tests #1655
Conversation
c760c72
to
5895846
Compare
Since #1603 got merged, we should un-ignore the |
5895846
to
8d2035f
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1655 +/- ##
==============================================
- Coverage 77.36% 77.21% -0.16%
==============================================
Files 128 128
Lines 20467 20499 +32
==============================================
- Hits 15835 15829 -6
- Misses 4632 4670 +38
Continue to review full report at Codecov.
|
aef0bd0
to
03603a3
Compare
f6e1361
to
c100d44
Compare
Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
c100d44
to
84d6f9f
Compare
Signed-off-by: Egor Ivkov e.o.ivkov@gmail.com
Description of the Change
Wait for peers to commit genesis in tests.
Also adds a genesis submission delay, which is useful as peers can take some time to connect to each other.
Benefits
Faster tests, less uncertainty points in tests that can cause failures.
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]