Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #1643: Wait for peers to commit genesis in tests #1655

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

e-ivkov
Copy link
Contributor

@e-ivkov e-ivkov commented Dec 1, 2021

Signed-off-by: Egor Ivkov e.o.ivkov@gmail.com

Description of the Change

Wait for peers to commit genesis in tests.
Also adds a genesis submission delay, which is useful as peers can take some time to connect to each other.

Benefits

Faster tests, less uncertainty points in tests that can cause failures.

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@e-ivkov e-ivkov self-assigned this Dec 1, 2021
@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Dec 1, 2021
@appetrosyan appetrosyan added Tests Optimization Something isn't working as well as it should labels Dec 1, 2021
@e-ivkov e-ivkov marked this pull request as draft December 1, 2021 12:20
@appetrosyan
Copy link
Contributor

Since #1603 got merged, we should un-ignore the 7_peers_1_fault test.

@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #1655 (84d6f9f) into iroha2-dev (068b228) will decrease coverage by 0.15%.
The diff coverage is 74.44%.

❗ Current head 84d6f9f differs from pull request most recent head 26e9d78. Consider uploading reports for the commit 26e9d78 to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1655      +/-   ##
==============================================
- Coverage       77.36%   77.21%   -0.16%     
==============================================
  Files             128      128              
  Lines           20467    20499      +32     
==============================================
- Hits            15835    15829       -6     
- Misses           4632     4670      +38     
Impacted Files Coverage Δ
...tests/integration_tests/multiple_blocks_created.rs 0.00% <0.00%> (ø)
client/tests/integration_tests/unstable_network.rs 0.00% <0.00%> (ø)
core/test_network/tests/sumeragi_with_mock.rs 0.23% <0.00%> (-0.01%) ⬇️
core/test_network/src/lib.rs 79.19% <83.33%> (-0.01%) ⬇️
client/tests/integration_tests/add_account.rs 100.00% <100.00%> (ø)
client/tests/integration_tests/add_asset.rs 100.00% <100.00%> (ø)
client/tests/integration_tests/add_domain.rs 100.00% <100.00%> (ø)
...lient/tests/integration_tests/asset_propagation.rs 100.00% <100.00%> (ø)
client/tests/integration_tests/config.rs 100.00% <100.00%> (ø)
client/tests/integration_tests/events.rs 100.00% <100.00%> (+1.07%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 068b228...26e9d78. Read the comment docs.

@e-ivkov e-ivkov force-pushed the wait-for-genesis branch 2 times, most recently from aef0bd0 to 03603a3 Compare December 3, 2021 17:19
@e-ivkov e-ivkov marked this pull request as ready for review December 3, 2021 17:19
@e-ivkov e-ivkov force-pushed the wait-for-genesis branch 2 times, most recently from f6e1361 to c100d44 Compare December 3, 2021 18:52
Signed-off-by: Egor Ivkov <e.o.ivkov@gmail.com>
@e-ivkov e-ivkov merged commit 607b051 into hyperledger:iroha2-dev Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST Optimization Something isn't working as well as it should Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants