-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconnect telemetry #1574
Merged
KalitaAlexey
merged 1 commit into
hyperledger:iroha2-dev
from
KalitaAlexey:reconnect-telemetry
Nov 10, 2021
Merged
Reconnect telemetry #1574
KalitaAlexey
merged 1 commit into
hyperledger:iroha2-dev
from
KalitaAlexey:reconnect-telemetry
Nov 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KalitaAlexey
requested review from
appetrosyan,
e-ivkov,
GaroRobe,
i1i1 and
s8sato
as code owners
November 2, 2021 09:26
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Nov 2, 2021
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1574 +/- ##
==============================================
- Coverage 74.16% 73.98% -0.19%
==============================================
Files 118 119 +1
Lines 19440 19651 +211
==============================================
+ Hits 14418 14538 +120
- Misses 5022 5113 +91
Continue to review full report at Codecov.
|
appetrosyan
reviewed
Nov 2, 2021
KalitaAlexey
force-pushed
the
reconnect-telemetry
branch
2 times, most recently
from
November 2, 2021 10:26
7fe7e0c
to
f855e25
Compare
KalitaAlexey
force-pushed
the
reconnect-telemetry
branch
from
November 3, 2021 10:43
f855e25
to
e8430c1
Compare
s8sato
reviewed
Nov 4, 2021
Closed
appetrosyan
suggested changes
Nov 4, 2021
appetrosyan
reviewed
Nov 4, 2021
KalitaAlexey
force-pushed
the
reconnect-telemetry
branch
from
November 8, 2021 09:38
e8430c1
to
d932cf8
Compare
KalitaAlexey
force-pushed
the
reconnect-telemetry
branch
from
November 8, 2021 09:41
d932cf8
to
7567334
Compare
appetrosyan
previously approved these changes
Nov 9, 2021
KalitaAlexey
force-pushed
the
reconnect-telemetry
branch
from
November 9, 2021 07:43
7567334
to
6275bb3
Compare
appetrosyan
previously approved these changes
Nov 9, 2021
e-ivkov
reviewed
Nov 9, 2021
s8sato
reviewed
Nov 9, 2021
s8sato
reviewed
Nov 9, 2021
KalitaAlexey
force-pushed
the
reconnect-telemetry
branch
from
November 10, 2021 08:07
6275bb3
to
e75c3b6
Compare
s8sato
reviewed
Nov 10, 2021
s8sato
reviewed
Nov 10, 2021
e-ivkov
previously approved these changes
Nov 10, 2021
KalitaAlexey
force-pushed
the
reconnect-telemetry
branch
from
November 10, 2021 13:02
e75c3b6
to
1351ff1
Compare
s8sato
reviewed
Nov 10, 2021
Signed-off-by: Alexey Kalita <kalita.alexey@outlook.com>
KalitaAlexey
force-pushed
the
reconnect-telemetry
branch
from
November 10, 2021 14:27
1351ff1
to
b817543
Compare
s8sato
approved these changes
Nov 10, 2021
e-ivkov
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Something isn't working
Enhancement
New feature or request
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexey Kalita kalita.alexey@outlook.com
Description of the Change
If telemetry fails to send a message, the node is going to reconnect in a few seconds.
While the telemetry is down, messages are skipped.
The period between reconnects can be customized with MIN_PERIOD and MAX_POWER
Issue
Closes #1546
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]