Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain metadata (#1141) #1541

Merged
merged 1 commit into from
Oct 25, 2021

Conversation

KalitaAlexey
Copy link

@KalitaAlexey KalitaAlexey commented Oct 20, 2021

Closes #1141

Signed-off-by: Alexey Kalita kalita.alexey@outlook.com

Description of the Change

Adding metadata to domains

Issue

Benefits

Possible Drawbacks

Usage Examples or Tests [optional]

Alternate Designs [optional]

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #1541 (18901b8) into iroha2-dev (f34d0be) will decrease coverage by 0.08%.
The diff coverage is 83.70%.

❗ Current head 18901b8 differs from pull request most recent head 11797a8. Consider uploading reports for the commit 11797a8 to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##           iroha2-dev    #1541      +/-   ##
==============================================
- Coverage       77.16%   77.08%   -0.09%     
==============================================
  Files             118      118              
  Lines           18974    18770     -204     
==============================================
- Hits            14641    14468     -173     
+ Misses           4333     4302      -31     
Impacted Files Coverage Δ
data_model/src/query.rs 24.36% <42.10%> (-0.89%) ⬇️
core/src/smartcontracts/isi/domain.rs 48.76% <55.55%> (+1.94%) ⬆️
core/src/smartcontracts/isi/query.rs 77.50% <95.23%> (-6.20%) ⬇️
permissions_validators/src/lib.rs 64.77% <98.33%> (+0.08%) ⬆️
core/src/smartcontracts/isi/mod.rs 78.40% <100.00%> (+3.08%) ⬆️
core/src/wsv.rs 93.62% <100.00%> (+0.74%) ⬆️
data_model/src/lib.rs 65.43% <100.00%> (+<0.01%) ⬆️
core/src/block_sync.rs 91.30% <0.00%> (-0.55%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24be5e1...11797a8. Read the comment docs.

core/src/wsv.rs Show resolved Hide resolved
core/src/wsv.rs Outdated Show resolved Hide resolved
i1i1
i1i1 previously approved these changes Oct 22, 2021
Copy link
Contributor

@s8sato s8sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it consistent about key type.
Then I'll approve after rebase

iroha/data_model/src/lib.rs

Lines 2674 to 2676 in 18901b8

pub struct Metadata {
map: BTreeMap<Name, Value>,
}

data_model/src/query.rs Outdated Show resolved Hide resolved
data_model/src/query.rs Outdated Show resolved Hide resolved
Signed-off-by: Alexey Kalita <kalita.alexey@outlook.com>
@KalitaAlexey KalitaAlexey merged commit c007d52 into hyperledger:iroha2-dev Oct 25, 2021
@KalitaAlexey KalitaAlexey deleted the domain-metadata branch October 25, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants