-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain metadata (#1141) #1541
Domain metadata (#1141) #1541
Conversation
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1541 +/- ##
==============================================
- Coverage 77.16% 77.08% -0.09%
==============================================
Files 118 118
Lines 18974 18770 -204
==============================================
- Hits 14641 14468 -173
+ Misses 4333 4302 -31
Continue to review full report at Codecov.
|
c9a4fa8
to
18901b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make it consistent about key type.
Then I'll approve after rebase
Lines 2674 to 2676 in 18901b8
pub struct Metadata { | |
map: BTreeMap<Name, Value>, | |
} |
Signed-off-by: Alexey Kalita <kalita.alexey@outlook.com>
18901b8
to
11797a8
Compare
Closes #1141
Signed-off-by: Alexey Kalita kalita.alexey@outlook.com
Description of the Change
Adding metadata to domains
Issue
Benefits
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]