GaroRobe/issue1485 #1517
Merged
GaroRobe/issue1485 #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
iroha2-dev
GaroRobe
requested review from
appetrosyan,
e-ivkov,
i1i1,
KalitaAlexey and
s8sato
as code owners
GaroRobe
force-pushed
the
GaroRobe/issue1485
branch
from
c6ecb01
to
da39dc0
Compare
i1i1
reviewed
Oct 11, 2021
i1i1
reviewed
Oct 11, 2021
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #1517 +/- ##
==============================================
- Coverage 76.47% 76.36% -0.12%
==============================================
Files 112 112
Lines 17826 17868 +42
==============================================
+ Hits 13633 13645 +12
- Misses 4193 4223 +30
Continue to review full report at Codecov.
|
Signed-off-by: Artem Ponomarev <ponomarev@soramitsu.co.jp>
GaroRobe
force-pushed
the
GaroRobe/issue1485
branch
from
be3cb4c
to
0dbcd21
Compare
i1i1
approved these changes
Oct 11, 2021
s8sato
reviewed
Oct 12, 2021
| @@ -376,6 +376,7 @@ pub mod private_blockchain { | |||
| )) | |||
| } | |||
| } | |||
| FindTransactionByHash(_query) => Ok(()), | |||
| @@ -542,6 +543,7 @@ pub mod private_blockchain { | |||
| Err(format!("Cannot access another account: {}.", account_id)) | |||
| } | |||
| } | |||
| FindTransactionByHash(_query) => Ok(()), | |||
|
I agree the possibility of success in random access by hashes is very low. |
s8sato
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added a new query - FindTransactionByHash. Will search a confirmed or rejected transaction by hash value.
Benefits
Possible Drawbacks
Doesn't account for any permissions or domains. Which might be wrong or need a setting.
Usage Examples or Tests [optional]
Alternate Designs [optional]