[BUG] Any information hasn't been propagated to the client when a client tries to register the account in the non-existent domain

[AlexStroke]

GIT commit hash

b783f10

Minimum working example

1. Install scripts/test_env.sh setup
2. Try to register the account in the non-existent domain
   ./iroha_client_cli account register --id="mad_hatter@looking_glass" --key="ed0120a753146e75b910ae5e2994dc8adea9e7d87e5d53024cfa310ce992f17106f92c"

Expected behaviour

Error: This domain non-exist

Actual behaviour

Any information hasn't been propagated

alexstrokelive@Aleksandrs-MacBook-Pro-9 test % ./iroha_client_cli account register --id="mad_hatter@looking_glass" --key="ed0120a753146e75b910ae5e2994dc8adea9e7d87e5d53024cfa310ce992f17106f92c"
User: alice@wonderland
{"PUBLIC_KEY":"ed01207233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0","PRIVATE_KEY":{"digest_function":"ed25519","payload":"9ac47abf59b356e0bd7dcbbbb4dec080e302156a48ca907e47cb6aea1d32719e7233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0"},"ACCOUNT_ID":"alice@wonderland","BASIC_AUTH":{"web_login":"mad_hatter","password":"ilovetea"},"TORII_API_URL":"http://127.0.0.1:8080","TORII_TELEMETRY_URL":"http://127.0.0.1:8180","TRANSACTION_TIME_TO_LIVE_MS":100000,"TRANSACTION_STATUS_TIMEOUT_MS":15000,"TRANSACTION_LIMITS":{"max_instruction_number":4096,"max_wasm_size_bytes":4194304},"ADD_TRANSACTION_NONCE":false}

Operating system

MacOS

Current environment

Source code build

Logs in JSON format

Log contents

alexstrokelive@Aleksandrs-MacBook-Pro-9 test % ./iroha_client_cli account register --id="mad_hatter@looking_glass" --key="ed0120a753146e75b910ae5e2994dc8adea9e7d87e5d53024cfa310ce992f17106f92c"
User: alice@wonderland
{"PUBLIC_KEY":"ed01207233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0","PRIVATE_KEY":{"digest_function":"ed25519","payload":"9ac47abf59b356e0bd7dcbbbb4dec080e302156a48ca907e47cb6aea1d32719e7233bfc89dcbd68c19fde6ce6158225298ec1131b6a130d1aeb454c1ab5183c0"},"ACCOUNT_ID":"alice@wonderland","BASIC_AUTH":{"web_login":"mad_hatter","password":"ilovetea"},"TORII_API_URL":"http://127.0.0.1:8080","TORII_TELEMETRY_URL":"http://127.0.0.1:8180","TRANSACTION_TIME_TO_LIVE_MS":100000,"TRANSACTION_STATUS_TIMEOUT_MS":15000,"TRANSACTION_LIMITS":{"max_instruction_number":4096,"max_wasm_size_bytes":4194304},"ADD_TRANSACTION_NONCE":false}
alexstrokelive@Aleksandrs-MacBook-Pro-9 test % cd ..                           
alexstrokelive@Aleksandrs-MacBook-Pro-9 iroha % git rev-parse --short HEAD
b783f10f
alexstrokelive@Aleksandrs-MacBook-Pro-9 iroha % cat test/peers/iroha0/.log 
2022-10-13T17:44:45.488734Z  INFO iroha: Hyperledgerいろは2にようこそ！
2022-10-13T17:44:45.489024Z  INFO iroha: (translation) Welcome to Hyperledger Iroha 2!
2022-10-13T17:44:45.503896Z  INFO iroha: Starting peer listen_addr=127.0.0.1:1337
2022-10-13T17:44:45.503943Z  INFO iroha_p2p::network: Binding listener listen_addr=127.0.0.1:1337
2022-10-13T17:44:45.504094Z  INFO iroha_p2p::network: Starting network actor listen_addr=127.0.0.1:1337
2022-10-13T17:44:45.512890Z  INFO iroha_core::kura: Loaded 0 blocks at init.
2022-10-13T17:44:45.516972Z ERROR iroha: Telemetry did not start
2022-10-13T17:44:45.517047Z  INFO handle{self=Network { peers: 0 } msg=Connected(Id { address: "127.0.0.1:56756", public_key: { digest: ed25519, payload: FACA9E8AA83225CB4D16D67F27DD4F93FC30FFA11ADC1F5C88FD5495ECC91020 } }, 15580931942437498738)}: iroha_p2p::network: Peer connected listen_addr=127.0.0.1:1337 count.new_peers=2 count.peers=1
2022-10-13T17:44:45.517561Z  INFO iroha: Starting Iroha
2022-10-13T17:44:45.517811Z  INFO handle{self=Network { peers: 1 } msg=Connected(Id { address: "127.0.0.1:56761", public_key: { digest: ed25519, payload: CC25624D62896D3A0BFD8940F928DC2ABF27CC57CEFEB442AA96D9081AAE58A1 } }, 16598413621405376918)}: iroha_p2p::network: Peer connected listen_addr=127.0.0.1:1337 count.new_peers=1 count.peers=2
2022-10-13T17:44:45.517917Z  INFO handle{self=Network { peers: 2 } msg=Connected(Id { address: "127.0.0.1:56762", public_key: { digest: ed25519, payload: 8E351A70B6A603ED285D666B8D689B680865913BA03CE29FB7D13A166C4E7F1F } }, 2317764054872731552)}: iroha_p2p::network: Peer connected listen_addr=127.0.0.1:1337 count.new_peers=0 count.peers=3
2022-10-13T17:44:45.773034Z  INFO run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Initializing iroha using the genesis block.
2022-10-13T17:44:45.774266Z  INFO run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Publishing genesis block. block_hash=982529a65e89f1461fa366d09c914cfdbac3791944d3ebb51ddc208877144451
2022-10-13T17:44:45.783013Z  INFO run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Created a block to commit. peer_role=ValidatingPeer block_hash=facf3307ad54f16f6c53610f0fcf7d34871ba07d5dfe113e4c4f5d5fe2a641a3
2022-10-13T17:44:45.790807Z ERROR run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Some events failed to be sent e=channel closed
2022-10-13T17:44:45.790879Z ERROR run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Some events failed to be sent e=channel closed
2022-10-13T17:44:45.791233Z  INFO run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Committing block prev_peer_role=ValidatingPeer new_peer_role=ValidatingPeer new_block_height=1 block_hash=facf3307ad54f16f6c53610f0fcf7d34871ba07d5dfe113e4c4f5d5fe2a641a3
2022-10-13T17:45:36.656546Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:56764}: warp::filters::trace: processing request
2022-10-13T17:45:36.657142Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:56764}: warp::filters::trace: finished processing with success status=200
2022-10-13T17:45:36.763841Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:56765}: warp::filters::trace: processing request
2022-10-13T17:45:36.765145Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:56765}: warp::filters::trace: finished processing with success status=200
2022-10-13T17:45:36.767958Z  INFO run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Forwarding tx to leader peer_addr=127.0.0.1:1337 peer_role=ValidatingPeer leader_addr=127.0.0.1:1339 tx_hash=80ec0156c463fa62559fa628a6215513197c68d7eca52a9a2024f51eee1332dd
2022-10-13T17:45:37.799717Z  WARN run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::block: Transaction validation failed reason=Failed to execute instruction of type register: Failed to find. Failed to find domain: `looking_glass` caused_by=Some(InstructionExecutionFail { instruction: Register(RegisterBox { object: EvaluatesTo { expression: Raw(Identifiable(NewAccount(NewAccount { id: Id { name: "mad_hatter", domain_id: Id { name: "looking_glass" } }, signatories: {{ digest: ed25519, payload: A753146E75B910AE5E2994DC8ADEA9E7D87E5D53024CFA310CE992F17106F92C }}, metadata: Metadata { map: {} } }))), _value_type: PhantomData } }), reason: "Failed to find. Failed to find domain: `looking_glass`" })
2022-10-13T17:45:37.801812Z  INFO run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Signed block candidate peer_role=ValidatingPeer block_hash=e4965075b994239f5252de93c77fd4b514255e693e9249a44af6b59350576ad6
2022-10-13T17:45:37.812016Z ERROR run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Some events failed to be sent e=channel closed
2022-10-13T17:45:37.812100Z ERROR run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Some events failed to be sent e=channel closed
2022-10-13T17:45:37.812292Z  INFO run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Committing block prev_peer_role=ValidatingPeer new_peer_role=Leader new_block_height=2 block_hash=e4965075b994239f5252de93c77fd4b514255e693e9249a44af6b59350576ad6
2022-10-13T17:46:10.543670Z  INFO request{method=POST path=/query version=HTTP/1.1 remote.addr=127.0.0.1:56766}: warp::filters::trace: processing request
2022-10-13T17:46:10.545303Z  INFO request{method=POST path=/query version=HTTP/1.1 remote.addr=127.0.0.1:56766}: warp::filters::trace: finished processing with success status=200
2022-10-13T17:46:36.515852Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:56767}: warp::filters::trace: processing request
2022-10-13T17:46:36.516645Z  INFO request{method=GET path=/pending_transactions version=HTTP/1.1 remote.addr=127.0.0.1:56767}: warp::filters::trace: finished processing with success status=200
2022-10-13T17:46:36.622871Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:56768}: warp::filters::trace: processing request
2022-10-13T17:46:36.623901Z  INFO request{method=POST path=/transaction version=HTTP/1.1 remote.addr=127.0.0.1:56768}: warp::filters::trace: finished processing with success status=200
2022-10-13T17:46:37.627533Z  INFO run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: sumeragi Doing block with 1 txs.
2022-10-13T17:46:37.631277Z  WARN run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::block: Transaction validation failed reason=Failed to execute instruction of type register: Failed to find. Failed to find domain: `looking_glass` caused_by=Some(InstructionExecutionFail { instruction: Register(RegisterBox { object: EvaluatesTo { expression: Raw(Identifiable(NewAccount(NewAccount { id: Id { name: "mad_hatter", domain_id: Id { name: "looking_glass" } }, signatories: {{ digest: ed25519, payload: A753146E75B910AE5E2994DC8ADEA9E7D87E5D53024CFA310CE992F17106F92C }}, metadata: Metadata { map: {} } }))), _value_type: PhantomData } }), reason: "Failed to find. Failed to find domain: `looking_glass`" })
2022-10-13T17:46:37.667490Z ERROR run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Some events failed to be sent e=channel closed
2022-10-13T17:46:37.667586Z ERROR run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Some events failed to be sent e=channel closed
2022-10-13T17:46:37.667814Z  INFO run{shutdown_receiver=Receiver { inner: Some(Inner { state: State { is_complete: false, is_closed: false, is_rx_task_set: false, is_tx_task_set: false } }) }}: iroha_core::sumeragi::main_loop: Committing block prev_peer_role=Leader new_peer_role=ValidatingPeer new_block_height=3 block_hash=64741f63fd8c58f4736f70f58b7bc85c204b0394162a634550723dcdee4f0025

Who can help?

@astrokov7

[dmitrivenger]

Confirmed, It seems like it is not a bug after all.
@appetrosyan and @astrokov7 FYI

[appetrosyan]

I need to explain this a bit more before closing.

The information not being propagated is a consequence of the deliberate simplicity of iroha_client_cli, while we could make the submission process blocking (and thus receive the error), you could equally set up another iroha_client_cli in another terminal to listen for pipeline events and get your information that way.

For a real client this isn't an issue, because a real deployment would already have a submitting process and a listening thread which would produce the desired effect. Given that we're keeping iroha_client_cli for very specific internal use-cases and we have been planning to axe it for a long time, I think it might be better to close this issue as not planned given the workaround described above (use another instance listening for pipeline events).

[Erigara]

@appetrosyan solution seems to be essentially oneliner, do we want to close it anyway?