-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of Name
struct
#1985
Comments
I think we can do something like Also right now |
I largely agree, but I have a few comments:
Only if necessary. The way I see it, a
We could try that. IMO it should really be |
If we'll consider interning of |
This seems like an interesting and highly maintained crate |
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…Name` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…Name` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…Name` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…Name` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…Name` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…Name` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…Name` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…Name` Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
…r#2365) Signed-off-by: Shanin Roman <shanin1000@yandex.ru> Signed-off-by: BAStos525 <jungle.vas@yandex.ru>
Name
is arepr(transparent)
struct wrappingstd::string::String
, which has a pointer, a length and a capacity.However, in most cases a name isn't modified, but instead, a new name is created. So in theory we could get rid of
capacity
, as we don't intend for theName
struct to be mutable (there isn't a single mutable borrow or mutableName
in the code-base).So we should investigate either using
std::str::str
or creating a custom structure for storingName
sThe text was updated successfully, but these errors were encountered: