Ubuntu 20.04 upgrade #1623
Closed
Ubuntu 20.04 upgrade #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Ebert <kim@indicio.tech>
|
Can one of the admins verify this patch? |
|
I believe this fixes #1622 |
pSchlarb
suggested changes
Dec 7, 2022
There was a problem hiding this comment.
Looks good to me.
Gitpod is starting, the tests are running.
Somme tests inside Gitpod errors due of timing issues, but since the tests in GHA and locally run i think it is nothing we can do about and most likely related to using gitpod.
Just a minor addition, i would also add the pyzmq pip install to the VSCode Dockerfile so that they both are nearly identical.
| @@ -67,6 +67,12 @@ RUN pip3 install -U \ | |||
| pep8-naming==0.6.1 \ | |||
| flake8==3.8.4 | |||
There was a problem hiding this comment.
Suggested change
| flake8==3.8.4 | |
| flake8==3.8.4 | |
| 'pyzmq==22.3.0' |
Comment on lines
+70
to
+74
| RUN pip3 install -U \ | ||
| # Required by setup.py | ||
| setuptools==50.3.2 \ | ||
| 'pyzmq==22.3.0' | ||
|
|
There was a problem hiding this comment.
Suggested change
| RUN pip3 install -U \ | |
| # Required by setup.py | |
| setuptools==50.3.2 \ | |
| 'pyzmq==22.3.0' |
setuptools duplication of L64
|
Changes are being incorporated into #1624 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for build