Update transaction structure description. #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could one of the committers please verify this patch? |
|
Can one of the admins verify this patch? |
…mework. Signed-off-by: Antonio Antonino <contact@antonioantonino.me>
| @@ -458,16 +458,10 @@ Adds a new node to the pool or updates an existing node in the pool | |||
|
|
|||
| - `dest` (base58-encoded string): | |||
|
|
|||
| Target Node's DID as base58-encoded string for 16 or 32 byte DID value. | |||
| Target Node's verkey as base58-encoded string for 16 or 32 byte DID value. | |||
There was a problem hiding this comment.
Yes, you are right. abbreviated verkeys are currently not supported. Can you please also fix the documentation for NODE request in requests.md?
There was a problem hiding this comment.
Hey! Just updated the same info in both requests.md and requests-new.md.
ashcherbakov
previously approved these changes
Mar 18, 2019
|
(ci) test this please |
Signed-off-by: Antonio Antonino <contact@antonioantonino.me>
|
(ci) test this please |
ashcherbakov
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description of the content of a transaction, and in particular a node transaction, is not consistent with the current workings of indy-node. While in the transactions README is stated that the
destfield of a node transaction is a node DID, it is instead the node verification key (as also shown by the test scripts, where the verification key of the node is written in the pool transaction, and not it public key).