Update start-nodes.md with working sudo syntax #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Could one of the committers please verify this patch? |
|
@coderintherye can you please fix the DCO? |
coderintherye
force-pushed
the
INDY-1964-start-nodes-doc-fix
branch
3 times, most recently
from
a86d137 to
72d480e
Compare
This fixes a line that will error out with permission denied due to the appending / redirect of output not having sudo, instead running it as an encapsulated sudo command Author: Kevin <kevin@kiva.org> Signed-off-by: Kevin OBrien <kevin@kiva.org>
coderintherye
force-pushed
the
INDY-1964-start-nodes-doc-fix
branch
from
72d480e to
219373e
Compare
|
@ashcherbakov Ok I think DCO has been resolved now |
|
(ci) test this please |
|
@coderintherye |
|
@ashcherbakov Ok, I merged in the upstream master and re-pushed and it's got the change in the right spot now, though I think the tests will have to run again |
|
(ci) test this please |
ashcherbakov
approved these changes
Feb 5, 2019
|
thanks @ashcherbakov , feels good to get something in, hopefully I will start contributing more substantive changes soon :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a line that will error out with permission denied due to the appending / redirect of output not having sudo, instead running it as an encapsulated sudo command. Fixes INDY-1964 https://jira.hyperledger.org/browse/INDY-1964