Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

@peterbroadhurst peterbroadhurst commented Mar 31, 2022

Update FireFly Core to exploit the parallelism enabled by hyperledger/firefly-dataexchange-https#56

  • Change spelling of Ack on callback interface to DX from commit to ack
    • This means there is a migration dependency on the DX-HTTPS v0.11.0 release (or other DX microservice implementations to upgrade to support the new API)
  • Refactor Data Exchange callback interface for asynchronous confirmation via callback
  • Blanket BLOB -> Blob rename
  • Add multi-insert support to Blobs in database layer
  • Add blobreceiver workers/config for parallel batched insertion of blobs to the DB
  • Dispatch MessageReceived events to insert batches as go routines
  • Add retry to SubmitOperationUpdate and remove error return
  • Updated manifest to pick up EthConnect v3.1.6

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst marked this pull request as draft March 31, 2022 22:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #656 (35aeebe) into main (f40ed6e) will increase coverage by 0.00%.
The diff coverage is 99.55%.

@@           Coverage Diff            @@
##             main     #656    +/-   ##
========================================
  Coverage   99.98%   99.98%            
========================================
  Files         313      315     +2     
  Lines       19113    19356   +243     
========================================
+ Hits        19110    19354   +244     
  Misses          2        2            
+ Partials        1        0     -1     
Impacted Files Coverage Δ
internal/data/data_manager.go 100.00% <ø> (ø)
internal/events/aggregator.go 100.00% <ø> (ø)
internal/shareddownload/download_manager.go 100.00% <ø> (ø)
internal/dataexchange/ffdx/dxevent.go 98.01% <98.01%> (ø)
internal/apiserver/route_get_data_blob.go 100.00% <100.00%> (ø)
internal/apiserver/route_post_data.go 100.00% <100.00%> (ø)
internal/blockchain/ethereum/ethereum.go 100.00% <100.00%> (ø)
internal/blockchain/fabric/fabric.go 100.00% <100.00%> (ø)
internal/broadcast/operations.go 100.00% <100.00%> (ø)
internal/config/config.go 100.00% <100.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40ed6e...35aeebe. Read the comment docs.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Copy link
Contributor

@awrichar awrichar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst merged commit 422ef89 into hyperledger:main Apr 2, 2022
@peterbroadhurst peterbroadhurst deleted the dx-parallel branch April 2, 2022 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants