-
Notifications
You must be signed in to change notification settings - Fork 242
Add self-describing enum support to OpenAPI definition #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
b6405d6 to
8b7f470
Compare
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
|
DCO stuff ate my code... will try and re-instate and re-open this for review 😢 |
Codecov Report
@@ Coverage Diff @@
## main #183 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 199 199
Lines 10859 10868 +9
=========================================
+ Hits 10859 10868 +9
Continue to review full report at Codecov.
|
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
|
ok - think I got my code back, and made DCO happy with my comments. |
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
nguyer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
One step on the journey to #111, allowing us to list the possible values for an
FFEnumtype (renamingLowerCasedType).This builds on a feature added to the OpenAPI schema generator in getkin/kin-openapi#411
Using the same approach in follow-on PRs, we can:
Message