Skip to content

Conversation

@peterbroadhurst
Copy link
Contributor

One step on the journey to #111, allowing us to list the possible values for an FFEnum type (renaming LowerCasedType).

This builds on a feature added to the OpenAPI schema generator in getkin/kin-openapi#411

Using the same approach in follow-on PRs, we can:

  • Add in field-level descriptions with translation keys
  • Remove the need for hard-coded schemas for complex objects like Message

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst marked this pull request as draft September 1, 2021 14:29
@peterbroadhurst
Copy link
Contributor Author

peterbroadhurst commented Sep 1, 2021

DCO stuff ate my code... will try and re-instate and re-open this for review 😢

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #183 (c3541e3) into main (6213b08) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          199       199           
  Lines        10859     10868    +9     
=========================================
+ Hits         10859     10868    +9     
Impacted Files Coverage Δ
pkg/fftypes/datatype.go 100.00% <ø> (ø)
pkg/fftypes/event.go 100.00% <ø> (ø)
pkg/fftypes/message.go 100.00% <ø> (ø)
pkg/fftypes/namespace.go 100.00% <ø> (ø)
pkg/fftypes/operation.go 100.00% <ø> (ø)
pkg/fftypes/transaction.go 100.00% <ø> (ø)
internal/events/webhooks/webhooks.go 100.00% <100.00%> (ø)
internal/oapispec/openapi3.go 100.00% <100.00%> (ø)
internal/tokens/https/https.go 100.00% <100.00%> (ø)
pkg/fftypes/enum.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6213b08...c3541e3. Read the comment docs.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@peterbroadhurst peterbroadhurst marked this pull request as ready for review September 1, 2021 14:35
@peterbroadhurst
Copy link
Contributor Author

peterbroadhurst commented Sep 1, 2021

ok - think I got my code back, and made DCO happy with my comments.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nguyer nguyer merged commit b4b9b39 into hyperledger:main Sep 8, 2021
@nguyer nguyer deleted the enums branch September 8, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants