Skip to content

Conversation

@SupernaviX
Copy link
Contributor

Proposed changes

Update firefly-cardanoconnect and firefly-cardanosigner images to newest versions


Types of changes

  • Version bump

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Other Information

I don't know what the usual process is for getting image updates into firefly-core, BUT it's most likely going to be months until the next firefly release. I'd like to keep the cardano images up to date with any changes we make, to avoid version mismatches when debugging issues.

Signed-off-by: Simon Gellis <simongellis@gmail.com>
@SupernaviX SupernaviX requested a review from a team as a code owner May 19, 2025 16:26
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (c827d0e) to head (85f7faf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1684   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files         342      342           
  Lines       30457    30457           
=======================================
  Hits        30445    30445           
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EnriqueL8 EnriqueL8 merged commit 1f68820 into hyperledger:main May 20, 2025
19 checks passed
@SupernaviX SupernaviX deleted the update-firefly-cardano branch May 20, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants