Skip to content

Conversation

@SupernaviX
Copy link
Contributor

Proposed changes

Use a fixed version for the base alpine image in manifest.json.


Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

Every time a new patch version comes out, it includes newer versions of dependencies which are installed (by fixed version) in the firefly-core dockerfile. This causes builds to fail. Fixing the patch version should keep the build stable.

Signed-off-by: Simon Gellis <simongellis@gmail.com>
@SupernaviX SupernaviX requested a review from a team as a code owner February 26, 2025 01:08
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (a96b39f) to head (b6f4439).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1645   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         339      339           
  Lines       29780    29780           
=======================================
  Hits        29768    29768           
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@EnriqueL8
Copy link
Contributor

@SupernaviX can you update this branch

@SupernaviX
Copy link
Contributor Author

@EnriqueL8 updated

@EnriqueL8 EnriqueL8 merged commit 1b9a69e into hyperledger:main Mar 10, 2025
19 checks passed
@SupernaviX SupernaviX deleted the fix-alpine-version branch March 10, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants