Skip to content

Conversation

@Shawn-Shaw-x
Copy link
Contributor

And create a README_zh_CN.md file that is a Cinnese translation copy of README.md.

Proposed changes

Please include a summary of the changes here and why we need those changes. And also let us know which issue is fixed.

Fixes # <issue_number_here>


Types of changes

  • [ x ] Documentation Update

Please make sure to follow these points

  • [ x ] I have read the contributing guidelines.
  • [ x ] I have performed a self-review of my own code or work.
  • [ x ] My changes generates no new warnings.

Screenshots (If Applicable)


Other Information

Raise PR again. Make DCO tool happy. Please check! Thank you! @EnriqueL8 @Chengxuan @jimthematrix

And create a README_zh_CN.md file that is a Cinnese translation copy of README.md.

Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
@Shawn-Shaw-x Shawn-Shaw-x requested a review from a team as a code owner January 7, 2025 16:50
Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
Shawn-Shaw-x and others added 3 commits January 9, 2025 21:45
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
@Chengxuan
Copy link
Contributor

Chengxuan commented Jan 10, 2025

@Shawn-Shaw-x Thank you for the first round of the translation. Making a start is always the hardest job. Thanks for doing this heavy-lifting job. I haven't finished all the reviews yet.

A few suggestions so far:

  • Let's keep the changes in 'doc-site' folder out of this PR, so this PR can be merged whenever we are happy with the main readme translation. You can raise a separate PR for the doc site translation. Please feel free to contact me if you are not familiar with the process.
  • Can you make sure formal title is used 您

please take a look at the suggestions so far and let me know if you have any questions.

Shawn-Shaw-x and others added 3 commits January 10, 2025 22:55
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
Shawn-Shaw-x and others added 7 commits January 11, 2025 00:04
Signed-off-by: shawn_shaw <cola_ocean@foxmail.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Shawn-Shaw-x and others added 4 commits January 28, 2025 09:35
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Shawn-Shaw-x and others added 13 commits January 28, 2025 09:53
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Co-authored-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: shawn_shaw <44858084+Shawn-Shaw-x@users.noreply.github.com>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Copy link
Contributor

@Chengxuan Chengxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

Copy link
Contributor

@EnriqueL8 EnriqueL8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shawn-Shaw-x and @Chengxuan for the reviews!

@EnriqueL8 EnriqueL8 merged commit 2bc127d into hyperledger:main Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants