Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup migrated contract JSON with full path #231

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

peterbroadhurst
Copy link
Contributor

The cleanup code for migrated JSON files failed to delete the file (so would run again on each restart).

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

Codecov Report

Merging #231 (6dfc487) into main (d71fcac) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #231      +/-   ##
==========================================
- Coverage   97.30%   97.25%   -0.05%     
==========================================
  Files          59       59              
  Lines        7502     7518      +16     
==========================================
+ Hits         7300     7312      +12     
- Misses        161      163       +2     
- Partials       41       43       +2     
Impacted Files Coverage Δ
ethconnect/internal/eth/compiler.go 97.93% <0.00%> (-2.07%) ⬇️
ethconnect/internal/events/eventstream.go 96.99% <0.00%> (-0.51%) ⬇️
ethconnect/internal/eth/txn.go 98.72% <0.00%> (ø)
ethconnect/internal/eth/send.go 95.55% <0.00%> (ø)
ethconnect/internal/errors/errors.go 100.00% <0.00%> (ø)
...connect/internal/contractregistry/contractstore.go 99.23% <0.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@vdamle vdamle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗑️

@vdamle vdamle merged commit 77e3c90 into hyperledger:main Oct 12, 2022
@vdamle vdamle deleted the cleanup branch October 12, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants