Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include the ",omitempty" in the JSON field name #29

Merged
merged 7 commits into from
Aug 8, 2022

Conversation

peterbroadhurst
Copy link
Contributor

No description provided.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #29 (4ad5202) into main (5a2539a) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main       #29      +/-   ##
===========================================
+ Coverage   99.90%   100.00%   +0.09%     
===========================================
  Files          38        38              
  Lines        2199      2206       +7     
===========================================
+ Hits         2197      2206       +9     
+ Misses          1         0       -1     
+ Partials        1         0       -1     
Impacted Files Coverage Δ
pkg/fftypes/bigint.go 100.00% <100.00%> (ø)
pkg/fftypes/jsonobject.go 100.00% <100.00%> (ø)
pkg/jsonmap/jsonmap.go 100.00% <100.00%> (ø)
pkg/fftypes/uuid.go 100.00% <0.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
…BigInt

Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Copy link
Contributor

@nguyer nguyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@nguyer nguyer merged commit 133c038 into hyperledger:main Aug 8, 2022
@nguyer nguyer deleted the map-omit branch August 8, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants