Fix panic on send to closed channel during snapshot shutdown#5384
Open
Ady0333 wants to merge 1 commit intohyperledger:mainfrom
Open
Fix panic on send to closed channel during snapshot shutdown#5384Ady0333 wants to merge 1 commit intohyperledger:mainfrom
Ady0333 wants to merge 1 commit intohyperledger:mainfrom
Conversation
Signed-off-by: Ady0333 <adityashinde1525@gmail.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR fixes a shutdown race in the ledger snapshot manager that could cause a peer panic.
Snapshot generation runs asynchronously in background goroutines. If the peer shuts down while a snapshot is still in progress, snapshotMgr.shutdown() could close internal channels before those goroutines finish, leading to a send on closed channel panic.
The fix coordinates shutdown with in-flight snapshot goroutines so shutdown is safe even when snapshot generation is ongoing.
Additional details
The snapshot manager now signals shutdown to background goroutines and waits for them to exit before closing channels.
Tested locally with
go test ./core/ledger/kvledger/....Also ran
go test ./core/ledger/kvledger -run Snapshot -vRelease Note
Fixes a shutdown race in the ledger snapshot manager that could cause a peer
panic when snapshots are generated during shutdown.