Use caching CI builds#762
Merged
Merged
Conversation
osamamagdy
force-pushed
the
feature/ci-caching
branch
from
83d393a to
c19e41b
Compare
osamamagdy
force-pushed
the
feature/ci-caching
branch
from
a0064d9 to
4dc644e
Compare
Contributor
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
Thanks for submitting this PR. I've tested it locally and it works great!
Could you please check my suggestions. We should also document this "option" in the config.mk.
Contributor
Author
|
@mbrandenburger thanks for your time to review. All changes applied and now the PR is ready 🙂 |
osamamagdy
force-pushed
the
feature/ci-caching
branch
from
9f80310 to
e3e4f24
Compare
osamamagdy
commented
May 16, 2024
Contributor
|
@osamamagdy thanks for the updates. Could you please rebase/squash your changes. I think we keep one commit for the |
osamamagdy
force-pushed
the
feature/ci-caching
branch
2 times, most recently
from
969a940 to
daa25b3
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
mbrandenburger
requested changes
May 17, 2024
Contributor
mbrandenburger
left a comment
mbrandenburger
left a comment
There was a problem hiding this comment.
i've noticed those whitespaces. Otherwise this looks very good to me.
osamamagdy
force-pushed
the
feature/ci-caching
branch
2 times, most recently
from
01da46b to
9870332
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
osamamagdy
force-pushed
the
feature/ci-caching
branch
from
9870332 to
2e5dc65
Compare
Contributor
Author
|
@mbrandenburger Thanks, all done now |
munapower
approved these changes
May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #753
This PR activates caching on a directory on the runner and mounting it to the go location where dependencies are installed inside the container building the app