WIP: sign with ed25519 PKCS11 keys #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This was tested with softhsm2 - Bump on miekg/pkcs11 to branch v3, which supports edwards Signed-off-by: Johann Westphall <johannwestphall@gmail.com>
Signed-off-by: Johann Westphall <johannwestphall@gmail.com>
Signed-off-by: Johann Westphall <johannwestphall@gmail.com>
Signed-off-by: Johann Westphall <johannwestphall@gmail.com>
Signed-off-by: Johann Westphall <johannwestphall@gmail.com>
Signed-off-by: Johann Westphall <johannwestphall@gmail.com>
Contributor
Author
|
I adjusted somethings after testing with my fabric-ca fork that support ed25519 both on SW and PCKS11 bccsps: https://github.com/johannww/fabric-ca |
Signed-off-by: Johann Westphall <johannwestphall@gmail.com>
Signed-off-by: Johann Westphall <johannwestphall@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of #29, I am trying to implement ed25519 support for PKCS11 bccsp. First I would like to ask if this interests the maintainers/contributors.
Anyway, I present what I have reached so far:
I would like to ask for assistance regarding the following topics:
opencryptoki?https://github.com/johannww/fabric-lib-go/blob/4a8e7bea6c980371f53c6121cdcabd20a0611283/bccsp/pkcs11/pkcs11.go#L1007-L1021
Thank you for your attention in advance.