Sample code for Node and Go #71
Conversation
samples/go/sample.go
Outdated
| func loadX509Cert(certFile string) (*x509.Certificate, error) { | ||
| cf, e := ioutil.ReadFile(certFile) | ||
| if e != nil { | ||
| return nil, e | ||
| } | ||
| cpb, _ := pem.Decode(cf) | ||
| return x509.ParseCertificate(cpb.Bytes) | ||
| } |
There was a problem hiding this comment.
This functionally duplicates the first 5 lines of the newIdentity() function so might be good to factor that into common code.
Note that cpb can be nil for bad input, which is checked for you using identity.CertificateFromPEM()
Makefile
Outdated
| @@ -65,6 +65,9 @@ lint: | |||
| staticcheck: | |||
| staticcheck $(base_dir)/pkg/... $(scenario_dir)/go | |||
|
|
|||
| sample-network:: vendor-chaincode | |||
There was a problem hiding this comment.
Not sure if the double : is supposed to be there or makes a difference?
samples/node/src/sample.ts
Outdated
| SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| import {connect, ConnectOptions, Identity, Signer, signers} from "fabric-gateway"; |
There was a problem hiding this comment.
Might be worth consistently using either " or ' around strings
samples/node/src/sample.ts
Outdated
| import * as grpc from '@grpc/grpc-js'; | ||
|
|
||
| const mspId = "Org1MSP" | ||
| const cryptoPath = path.resolve(__dirname, '../', '..', '..', 'scenario', 'fixtures', 'crypto-material', 'crypto-config', 'peerOrganizations', 'org1.example.com'); |
There was a problem hiding this comment.
I don't think the / should be there in the path components. path.resolve() should be putting the correct separators in there
samples/node/src/sample.ts
Outdated
| let gateway; | ||
| try { |
There was a problem hiding this comment.
You definitely don't have a gateway until the connect completes successfully so could start the try block just after the connect and have:
const gateway = connect(options);
try {
...
} finally {
gateway.close()
}
samples/node/src/sample.ts
Outdated
| try { | ||
| const privateKeyPem = await fs.promises.readFile(keyPath); | ||
| const privateKey = crypto.createPrivateKey(privateKeyPem); | ||
| const signer: Signer = signers.newPrivateKeySigner(privateKey); |
There was a problem hiding this comment.
I personally wouldn't specify the type of signer as it's inferred from the return type of newPrivateKeySigner()
samples/node/src/sample.ts
Outdated
| }; | ||
|
|
||
| const tlsRootCert = fs.readFileSync(tlsCertPath); | ||
| const grpcOptions = { |
There was a problem hiding this comment.
I personally would explicitly specify the type as Partial<ChannelOptions> so the compiler can ensure you're using valid property names/types. Or embed it straight into the new GrpcClient() call so the compiler can infer the type. I think then you'll see any error at the point of definition rather than the point of use
samples/node/src/sample.ts
Outdated
| } catch (e) { | ||
| console.log(e); | ||
| } |
There was a problem hiding this comment.
I think I'd ditch this catch block and invoke the main() function with main().catch(console.error); so anything thrown gets logged to stderr
Very basic samples demonstrating how to write a client application using the gateway SDKs Go and Node for now. Signed-off-by: andrew-coleman <andrew_coleman@uk.ibm.com>
Very basic samples demonstrating how to write a client application using the gateway SDKs
Go and Node for now.
Signed-off-by: andrew-coleman andrew_coleman@uk.ibm.com